From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC347C433E6 for ; Thu, 4 Feb 2021 06:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC44464F44 for ; Thu, 4 Feb 2021 06:14:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231886AbhBDGOS (ORCPT ); Thu, 4 Feb 2021 01:14:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230281AbhBDGOP (ORCPT ); Thu, 4 Feb 2021 01:14:15 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB8EC0613ED for ; Wed, 3 Feb 2021 22:13:35 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id gx20so1177562pjb.1 for ; Wed, 03 Feb 2021 22:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncXEJ1dZpoFNtJ7RLMyE5p7WlT1xC95XJWCpTzmVYWE=; b=XPBT5TFm7JgmY9O9VISnJGEkGoPrAlzNb9PchDy7LZiduD7wP1ehIzarhoSUk0UvaB FBjNqlEb6tjBq25k4rdQHtYxcBNVHDAZ/Z0ETVd0tZ7xogpZ83BbQ3yG++6S/b/P2Vvu 4RupnOrIdn4bf8yyktL2+fhZlIz/LNAG9m+TcEINqoCdyIkT91ZYgTO/I3tJcsF+Dr8f sX53Ujseq68ZclyDHO086NvofeGGmd7QI/bTQ3UoN7F15nLXDoj9+vCBn4YYlsYreoiQ GIOGSfavRdbmTty94m4EAlbV361SEPjuOVQkXQFEWB2yPHuQhLXLMzrNv96/GunrvQs9 Il5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncXEJ1dZpoFNtJ7RLMyE5p7WlT1xC95XJWCpTzmVYWE=; b=XZkw0KqHiyT9yHH/lMqG+XZKoK2I/V1rTOTzGDFUK9hO8Xsfdk2e8wezl64v02YsjX 0OGuTprcbslKEc2FVaVA644iKrefN9srR/jmUHhe/NLHg5qkT/0qlR0c5L+K3rfeE+mE M1UUDJIEFsf37tBGDkaUtGpj+frjpJlx2Wvrx1xeDmfeFIdHxvH3DiSvXF80BkCPOIG1 3zsgvlZoHJ7KWE3Gms5ksr+KUkmgY7T8HHNWC/fpWn0ishMm8QAyfaIhIYrZg6hqtDp6 A/rE1RDB/swiInEkiY6XHVbp/aY1jf8wKDnc/70uwSPR+sJcaCz3G7KcZC2FpbZlmBaw gKXQ== X-Gm-Message-State: AOAM532V9CZpJMgbeD/stbUWMhMIy31gfYcTHH+/5QDu/Dsfqu3UAAZR dkiSvnxDDraYaPASlM4XqasIh5pMhBC6Zc2cDrO5Mg== X-Google-Smtp-Source: ABdhPJyKDThP0trUUIdsz6iIijzlmPEakH+sB7moIhqkBdUBvPAWclyV2e4vceezFD0v56p2N6y41FMPXMzREaczZYM= X-Received: by 2002:a17:902:ed94:b029:de:8844:a650 with SMTP id e20-20020a170902ed94b02900de8844a650mr6808235plj.56.1612419214450; Wed, 03 Feb 2021 22:13:34 -0800 (PST) MIME-Version: 1.0 References: <20210130004401.2528717-1-ndesaulniers@google.com> <20210130004401.2528717-2-ndesaulniers@google.com> <20210130015222.GC2709570@localhost> In-Reply-To: <20210130015222.GC2709570@localhost> From: Nick Desaulniers Date: Wed, 3 Feb 2021 22:13:22 -0800 Message-ID: Subject: Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice To: Nathan Chancellor Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Sedat Dilek , LKML , clang-built-linux , Linux Kbuild mailing list , linux-arch , Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2021 at 5:52 PM Nathan Chancellor wrote: > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs, and makes adding future versions more straightforward. > > > > GCC since ~4.8 has defaulted to this DWARF version implicitly. > > > > Suggested-by: Arvind Sankar > > Suggested-by: Fangrui Song > > Suggested-by: Nathan Chancellor > > Suggested-by: Masahiro Yamada > > Signed-off-by: Nick Desaulniers > > One comment below: > > Reviewed-by: Nathan Chancellor > > > --- > > Makefile | 5 ++--- > > lib/Kconfig.debug | 16 +++++++++++----- > > 2 files changed, 13 insertions(+), 8 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 95ab9856f357..d2b4980807e0 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -830,9 +830,8 @@ ifneq ($(LLVM_IAS),1) > > KBUILD_AFLAGS += -Wa,-gdwarf-2 > > It is probably worth a comment somewhere that assembly files will still > have DWARF v2. Such a comment should have gone on commit b8a9092330da ("Kbuild: do not emit debug info for assembly with LLVM_IAS=1") It's also more complicated than "assembly files will still have DWARF v4," due to the LLVM_IAS check. Further, such a comment would be inappropriate for patch 1 of the series, which simply changes a Kconfig option into a choice. I will add a note to the commit message of patch 2, and carry your reviewed by tag. Please nack v8 (which I plan to send imminently) if you disagree. -- Thanks, ~Nick Desaulniers