From: Nick Desaulniers <ndesaulniers@google.com>
To: linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Kees Cook <keescook@chromium.org>
Cc: linux-tip-commits@vger.kernel.org,
Arvind Sankar <nivedita@alum.mit.edu>,
Fangrui Song <maskray@google.com>,
x86@kernel.org, clang-built-linux <llvm@lists.linux.dev>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [tip: x86/build] x86/build: Don't build CONFIG_X86_32 as -ffreestanding
Date: Thu, 7 Apr 2022 10:01:32 -0700 [thread overview]
Message-ID: <CAKwvOdkQeSx3uy25KaTrX=ywc26wDEefXHbCB_ifGot+yXGvHQ@mail.gmail.com> (raw)
In-Reply-To: <164934565464.389.2546833245037255032.tip-bot2@tip-bot2>
On Thu, Apr 7, 2022 at 8:34 AM tip-bot2 for Nick Desaulniers
<tip-bot2@linutronix.de> wrote:
>
> The following commit has been merged into the x86/build branch of tip:
>
> Commit-ID: 9b2687f29bc1a050ffd63b425129aa9db987e4f3
> Gitweb: https://git.kernel.org/tip/9b2687f29bc1a050ffd63b425129aa9db987e4f3
> Author: Nick Desaulniers <ndesaulniers@google.com>
> AuthorDate: Thu, 03 Feb 2022 12:40:25 -08:00
> Committer: Borislav Petkov <bp@suse.de>
> CommitterDate: Thu, 07 Apr 2022 11:55:42 +02:00
>
> x86/build: Don't build CONFIG_X86_32 as -ffreestanding
>
> -ffreestanding typically inhibits "libcall optimizations" where calls to
> certain library functions can be replaced by the compiler in certain
> cases to calls to other library functions that may be more efficient.
> This can be problematic for embedded targets that don't provide full
> libc implementations.
>
> -ffreestanding inhibits all such optimizations, which is the safe
> choice, but generally we want the optimizations that are performed. The
> Linux kernel does implement a fair amount of libc routines. Instead of
> -ffreestanding (which makes more sense in smaller images like kexec's
> purgatory image), prefer -fno-builtin-* flags to disable the compiler
> from emitting calls to functions which may not be defined.
>
> If you see a linkage failure due to a missing symbol that's typically
> defined in a libc, and not explicitly called from the source code, then
> the compiler may have done such a transform. You can either implement
> such a function (i.e. in lib/string.c) or disable the transform outright
> via -fno-builtin-* flag (where * is the name of the library routine,
> i.e. -fno-builtin-bcmp).
>
> i386_defconfig build+boot tested with GCC and Clang. Removes a pretty
> old TODO from the code base.
>
> [kees: These libcall optimizations are specifically needed to allow Clang
> to correctly optimize the string functions under CONFIG_FORTIFY_SOURCE.]
Right, but...
I think we found that doing so leads to a boot regression for i386
when built w/ clang because:
https://github.com/ClangBuiltLinux/linux/issues/1583
https://github.com/llvm/llvm-project/issues/53645
TL;DR
In doing such libcall optimizations, LLVM drops the -mregparm=3
calling convention...on the caller's side and not the callee's.
Boris, Can I send you a patch to replace this one (with a guard for
clang) or a patch on top? i.e. what base would you prefer me to use.
Using mainline:
```
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 63d50f65b828..c94de779e334 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -100,8 +100,13 @@ ifeq ($(CONFIG_X86_32),y)
include $(srctree)/arch/x86/Makefile_32.cpu
KBUILD_CFLAGS += $(cflags-y)
- # temporary until string.h is fixed
+ # LLVM is dropping -mregparm=3 from callers when doing libcall
+ # optimization.
+ # https://github.com/ClangBuiltLinux/linux/issues/1583
+ # https://github.com/llvm/llvm-project/issues/53645
+ ifndef CONFIG_CC_IS_CLANG
KBUILD_CFLAGS += -ffreestanding
+ endif
ifeq ($(CONFIG_STACKPROTECTOR),y)
ifeq ($(CONFIG_SMP),y)
```
but happy to rebase onto whichever and put a commit message on that.
We'll bump up the priority on getting that fixed.
>
> Fixes: 6edfba1b33c7 ("[PATCH] x86_64: Don't define string functions to builtin")
> Suggested-by: Arvind Sankar <nivedita@alum.mit.edu>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Reviewed-by: Fangrui Song <maskray@google.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Link: https://lore.kernel.org/r/20200817220212.338670-5-ndesaulniers@google.com
> Link: https://lore.kernel.org/r/20220203204025.1153397-1-keescook@chromium.org
> ---
> arch/x86/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 1abd7cc..670fe40 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -100,9 +100,6 @@ ifeq ($(CONFIG_X86_32),y)
> include $(srctree)/arch/x86/Makefile_32.cpu
> KBUILD_CFLAGS += $(cflags-y)
>
> - # temporary until string.h is fixed
> - KBUILD_CFLAGS += -ffreestanding
> -
> ifeq ($(CONFIG_STACKPROTECTOR),y)
> ifeq ($(CONFIG_SMP),y)
> KBUILD_CFLAGS += -mstack-protector-guard-reg=fs -mstack-protector-guard-symbol=__stack_chk_guard
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2022-04-07 17:02 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 22:02 [PATCH 0/4] -ffreestanding/-fno-builtin-* patches Nick Desaulniers
2020-08-17 22:02 ` [PATCH 1/4] Makefile: add -fno-builtin-stpcpy Nick Desaulniers
2020-08-17 22:31 ` H. Peter Anvin
2020-08-17 23:36 ` Nick Desaulniers
2020-08-18 19:21 ` Kees Cook
2020-08-18 7:10 ` Ard Biesheuvel
2020-08-18 7:25 ` Greg KH
2020-08-18 7:29 ` Ard Biesheuvel
2020-08-18 7:34 ` Greg KH
2020-08-18 19:23 ` Kees Cook
2020-08-17 22:02 ` [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp" Nick Desaulniers
2020-08-18 5:44 ` Nathan Chancellor
2020-08-18 18:00 ` Nick Desaulniers
2020-08-18 19:24 ` Kees Cook
2020-08-17 22:02 ` [PATCH 3/4] x86/boot: use -fno-builtin-bcmp Nick Desaulniers
2020-08-18 19:24 ` Kees Cook
2020-08-17 22:02 ` [PATCH 4/4] x86: don't build CONFIG_X86_32 as -ffreestanding Nick Desaulniers
2020-08-18 19:24 ` Kees Cook
2021-01-07 0:27 ` Fangrui Song
2022-04-07 15:34 ` [tip: x86/build] x86/build: Don't " tip-bot2 for Nick Desaulniers
2022-04-07 17:01 ` Nick Desaulniers [this message]
2022-04-07 22:28 ` Borislav Petkov
2020-08-17 22:44 ` [PATCH 0/4] -ffreestanding/-fno-builtin-* patches H. Peter Anvin
2020-08-18 17:56 ` Nick Desaulniers
2020-08-18 19:02 ` H. Peter Anvin
2020-08-18 19:13 ` Linus Torvalds
2020-08-18 19:25 ` Nick Desaulniers
2020-08-18 19:58 ` Nick Desaulniers
2020-08-19 12:19 ` Clement Courbet
2020-08-18 20:24 ` Arvind Sankar
2020-08-18 20:27 ` Nick Desaulniers
2020-08-18 20:58 ` Nick Desaulniers
2020-08-18 21:41 ` Arvind Sankar
2020-08-18 21:51 ` Dávid Bolvanský
2020-08-18 21:59 ` Nick Desaulniers
2020-08-18 22:05 ` Dávid Bolvanský
2020-08-18 23:22 ` Nick Desaulniers
2020-08-20 14:56 ` Rasmus Villemoes
2020-08-20 17:56 ` Arvind Sankar
2020-08-20 18:05 ` Dávid Bolvanský
2020-08-20 23:33 ` Linus Torvalds
2020-08-21 17:29 ` Arvind Sankar
2020-08-21 17:54 ` Linus Torvalds
2020-08-21 18:02 ` Linus Torvalds
2020-08-21 19:14 ` Arvind Sankar
2020-08-21 19:23 ` Linus Torvalds
2020-08-21 19:57 ` Arvind Sankar
2020-08-21 20:03 ` Peter Zijlstra
2020-08-21 21:39 ` Linus Torvalds
2020-08-22 0:12 ` Nick Desaulniers
2020-08-22 12:20 ` David Laight
2020-08-21 6:45 ` Rasmus Villemoes
2020-08-24 15:57 ` Masahiro Yamada
2020-08-24 17:34 ` Arvind Sankar
2020-08-25 7:10 ` Nick Desaulniers
2020-08-25 7:31 ` Nick Desaulniers
2020-08-25 12:28 ` Masahiro Yamada
2020-08-25 14:02 ` Nick Desaulniers
2020-08-26 13:28 ` Masahiro Yamada
2020-08-18 21:53 ` David Laight
2020-08-20 22:41 ` H. Peter Anvin
2020-08-20 23:17 ` Arvind Sankar
2020-08-18 19:35 ` Nick Desaulniers
2020-08-18 22:25 ` Arvind Sankar
2020-08-18 22:59 ` Nick Desaulniers
2020-08-18 23:51 ` Arvind Sankar
2020-08-19 0:20 ` Arvind Sankar
2020-08-19 8:26 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdkQeSx3uy25KaTrX=ywc26wDEefXHbCB_ifGot+yXGvHQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=bp@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maskray@google.com \
--cc=nathan@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).