From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38220C2B9F4 for ; Mon, 14 Jun 2021 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0552A6124B for ; Mon, 14 Jun 2021 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbhFNTGk (ORCPT ); Mon, 14 Jun 2021 15:06:40 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:39692 "EHLO mail-lf1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbhFNTGi (ORCPT ); Mon, 14 Jun 2021 15:06:38 -0400 Received: by mail-lf1-f42.google.com with SMTP id p17so22753237lfc.6 for ; Mon, 14 Jun 2021 12:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iEYOmaWczuFfQkImwxqrXdOlZrbm3xpPMO2bFpeG0wM=; b=fOSQmcG3PVq3wF00JgOqcV8GrvIf3ssnAPjyJkX5nhEi7AqouXXwJRy3qpdOewql/Z ouIEL8osdg6qe6KX63lktAKS5/U6ICu7nOwqKjQrpbCQYHlfgUiUpbfzPTpo96A7vTNW nne4hFVN309bC5FPM80nvl+Tjj9VEhQYqT/v6xhkqkteNZrfVUGBYaHc29IaM7RFjiy+ DTAtfhl9F1NGTFOO3foUIwRQji5Vtivzb+wUxu6tH5zJbzg9c48Z7cZWo0iJw1esM2mp FMNf8mP6EUF7J5uy9I/AUeG5tARA+6CgS1UYy1jEwTj6CA6yF+FtOS9IPK3menDMJYpf POag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iEYOmaWczuFfQkImwxqrXdOlZrbm3xpPMO2bFpeG0wM=; b=WzOlgMCK9URFPxtrDNXFItrM3rw7LxAp6MY75DjpfcEsptcNXm1KTtofdlyl+w7xeo 3Q0I3RAjlOr9x82zY7by2Ker0KQQOB0a6p2vQcbdE5wzIrECDPCiG7Ct6Vm9JHtYYWHU aDj2IuRtU3APIIwBH/NmIOy4Vj+K0slb/NYe7lLGU+IhCxC2KPVc7TJqnKtMd7AVjx6B CMVwgcnb8fHp7MDGEqLDgSpijcyv2WWwuzBddq6YMP483waKk+jEKuwWrF5/HxTDL9oF OPK7rK/id6KMhvxD/5lAgwtsbzWVc4QNKqZVJQrahoK8lmAudYZrEkmHKlhEnyYt8oZf Ccsg== X-Gm-Message-State: AOAM5320s8Ej7cqIG38rKBgY2V3VDdryddt2x1e5zOHR4i8PrDrwszuW 8rKPHAVcqHwngDsUZO5bjW2KyW2sX7yFK53Lsw6KWA== X-Google-Smtp-Source: ABdhPJxTlVDzkoB3Ktqt4nmgdqXbH/OnHgNc0oGNz0XTro7/H3wybhJwOB12KozxgndUUa6F54nyoCmw6RvQRHwCfnk= X-Received: by 2002:a05:6512:51c:: with SMTP id o28mr12865111lfb.297.1623697406791; Mon, 14 Jun 2021 12:03:26 -0700 (PDT) MIME-Version: 1.0 References: <20210614162018.GD68749@worktop.programming.kicks-ass.net> In-Reply-To: From: Nick Desaulniers Date: Mon, 14 Jun 2021 12:03:15 -0700 Message-ID: Subject: Re: [PATCH] gcov,x86: Mark GCOV broken for x86 To: Borislav Petkov Cc: Peter Zijlstra , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Peter Oberparleiter , LKML , Johannes Berg , Nathan Chancellor , Kees Cook , Marco Elver , Mark Rutland Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 11:21 AM Borislav Petkov wrote: > > On Mon, Jun 14, 2021 at 11:05:35AM -0700, Nick Desaulniers wrote: > > __attribute__((no_instrument_function)) is already wired to not emit > > calls to mcount()/fentry(). I think extending it to also apply to > > coverage (-fprofile-arcs) and instrumentation based profiling > > (-fprofile-generate) is reasonable. > > Is anyone going to ping the gcc folks so that they do it too or should > we open a bug over there simply? Yes, I will file a bug (or two) against GCC and then post the links on the other thread (re: pgo) since that already has the toolchains mailing list cc'ed. -- Thanks, ~Nick Desaulniers