From: Nick Desaulniers <ndesaulniers@google.com>
To: "Eric W . Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, hpa@zytor.com,
Simon Horman <horms@verge.net.au>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <natechancellor@gmail.com>,
x86@kernel.org, Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kexec@lists.infradead.org
Subject: Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr
Date: Tue, 21 Aug 2018 09:26:24 -0700 [thread overview]
Message-ID: <CAKwvOdkWL_2yTnJqM6n6R9UCPwY4iz-9BQYGN2MDAk9EzumUvA@mail.gmail.com> (raw)
In-Reply-To: <87bm9v28rh.fsf@xmission.com>
On Tue, Aug 21, 2018 at 5:40 AM Eric W. Biederman <ebiederm@xmission.com> wrote:
>
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
> > On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> >>
> >> + akpm, Linus
> >>
> >> Bumping for review.
> >
> > Ugh. I am not personally a huge fan of this endless "fix up one at a time".
> >
> > Just do a patch that removes current_text_addr() entirely and be done
> > with it, if that's what we want the end result to be.
> >
> > Don't bother with these small "let's remove the remaining ones one by
> > one". Just get it over and done with.
Linus,
No problem. Will send a V2 that rips off the band-aid.
I explained my thoughts on the process more in
https://lkml.org/lkml/2018/8/1/1689, which akpm agreed with. I was
hoping that I wouldn't have to bother you with a tree-wide change, but
if code review takes 3 weeks...
Also, I was hoping to save the small but many clean ups as starter
patches for some newbies that we're asking me how to get started
contributing to the kernel, but I can find other good first bugs for
them.
>
> One is generic code the other is assembly but the both appear to do the
> same thing without unexpected complexity.
>
> That said the patch earlier in this thread has clearly never been
> compiled as it is using THIS_IP instead of _THIS_IP_ and there is not
> a define of THIS_IP in the kernel.
Eric,
Please triple check your email client or whatever you're using to
download patches, as I suspect one of them may be stripping
leading+trailing underscores. That would be quite problematic for
code review or applying patch files. I've seen some text renderers
treat the underscores as markdown and italicize the contained word.
https://lkml.org/lkml/2018/8/1/1608 shows the underscores.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-08-21 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 21:08 [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr Nick Desaulniers
2018-08-08 23:06 ` Nick Desaulniers
2018-08-13 21:32 ` Nick Desaulniers
2018-08-20 17:58 ` Nick Desaulniers
2018-08-20 23:48 ` Linus Torvalds
2018-08-21 12:40 ` Eric W. Biederman
2018-08-21 16:26 ` Nick Desaulniers [this message]
[not found] ` <20180821202900.208417-1-ndesaulniers@google.com>
[not found] ` <207784db-4fcc-85e7-a0b2-fec26b7dab81@gmx.de>
[not found] ` <c62e4e00-fb8f-19a6-f3eb-bde60118cb1a@zytor.com>
[not found] ` <81141365-8168-799b-f34f-da5f92efaaf9@zytor.com>
[not found] ` <7f49eeab-a5cc-867f-58fb-abd266f9c2c9@zytor.com>
[not found] ` <6ca8a1d3-ff95-e9f4-f003-0a5af85bcb6f@zytor.com>
[not found] ` <CA+55aFzuSCKfmgT9efHuwtan+m3+bPh4BpwbZwn5gGX_H=Thuw@mail.gmail.com>
2018-08-27 7:43 ` [PATCH] treewide: remove current_text_addr Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkWL_2yTnJqM6n6R9UCPwY4iz-9BQYGN2MDAk9EzumUvA@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).