From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-28.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AD4C43460 for ; Fri, 30 Apr 2021 22:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 151A561289 for ; Fri, 30 Apr 2021 22:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231840AbhD3WuF (ORCPT ); Fri, 30 Apr 2021 18:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbhD3WuD (ORCPT ); Fri, 30 Apr 2021 18:50:03 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 867BBC06174A for ; Fri, 30 Apr 2021 15:49:14 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id j4so72972659lfp.0 for ; Fri, 30 Apr 2021 15:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iDj/KqljFidoYmUB3JwJD5XIMfVHo2ILy+QB0Z4+7eY=; b=Hdkd+OSzAEW5kG/LYPVp9EWvvnwA2RN6Zcf57KQxFF0bLBLXPESKJS049xblm7jeMT P9ad+q7y1qPiqnStuvGV02DOckOp2WORBpSUYodQ5FUg+S/bj2AIRvQMtJ6GqHPh1lOc 8WHv7ObX+EvIy/BAkLgIcbEoDj/DcCZ0/yHq3g7WqTJORopr6+IOwEwylce/YkEwrQ/e KqwoDBr4d6QCwGoVs02Bon9aBUaRh2fhFJrBYoo0guOrgodpRUEzt9PK/gECsDMy8IxA wxRYTIXbDLb+8HwzUilL5s1OkZyJw9FfEeFL3PAM1MhGr93iUtBGTHocxGWlEpvp85OB 4Yjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iDj/KqljFidoYmUB3JwJD5XIMfVHo2ILy+QB0Z4+7eY=; b=l5J5xwocS+8tHP4ophLjIpQEqpkFawVNT6p9CNqKSQUPuEoAyQrUtRVMZIcOPDfxD5 x5+hIZwmM+1pRHirQovKeH0RJ50RjBoAlrmfV5F74vRoFUtS2C8cdKrTpGkAKGrnNEfm mhHTt7AlCl9dRQaKY0onyLwWdBT1IR/5Epk7cNtrs2zpf7eRdQ2nXoFyRH5Ws8bKIOI4 MiXVRuibuKT8bO0Nr870yHSlrGyyifc9wXxLoXtlIQvjdy/7KnqNHKfKLB9NslRsROt+ oP67SEyoV6S1q20mPA5prVYpdAv5yEU1wLVoqwmaGqH413X19brGxB7zzLtvoN3SBISr RauA== X-Gm-Message-State: AOAM532//yrcUrAKAhqEht0AP2UD9U50EU7SQvVPQPMbSDK2RrO16tGm SJB/XSa+y4n2kqGxb/LEShgCkdjcH70M2weP90jsCQ== X-Google-Smtp-Source: ABdhPJywWmeJ2QmLmmKiD5eZ7WjRzX8EqYzEBw8K21R8QXzgYftmJURNZ0tjHvWjnKYgivNjQo7Z1wuvpbmKD0HDKHA= X-Received: by 2002:a05:6512:2190:: with SMTP id b16mr4831831lft.122.1619822952803; Fri, 30 Apr 2021 15:49:12 -0700 (PDT) MIME-Version: 1.0 References: <20210429012350.600951-1-nathan@kernel.org> In-Reply-To: <20210429012350.600951-1-nathan@kernel.org> From: Nick Desaulniers Date: Fri, 30 Apr 2021 15:49:00 -0700 Message-ID: Subject: Re: [PATCH] Makefile: Move -Wno-unused-but-set-variable out of GCC only block To: Nathan Chancellor Cc: Masahiro Yamada , Michal Marek , Linux Kbuild mailing list , LKML , clang-built-linux , "# 3.4.x" , Jian Cai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 6:24 PM Nathan Chancellor wrote: > > Currently, -Wunused-but-set-variable is only supported by GCC so it is > disabled unconditionally in a GCC only block (it is enabled with W=1). > clang currently has its implementation for this warning in review so > preemptively move this statement out of the GCC only block and wrap it > with cc-disable-warning so that both compilers function the same. > > Cc: stable@vger.kernel.org > Link: https://reviews.llvm.org/D100581 Thanks for the patch. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers (That's actually one of Jian's teammates working on implementing that warning). Tested with https://reviews.llvm.org/D100581 applied, which I do fully expect to land in LLVM soon. > Signed-off-by: Nathan Chancellor > --- > Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index f03888cdba4e..911d839cfea8 100644 > --- a/Makefile > +++ b/Makefile > @@ -775,16 +775,16 @@ KBUILD_CFLAGS += -Wno-gnu > KBUILD_CFLAGS += -mno-global-merge > else > > -# These warnings generated too much noise in a regular build. > -# Use make W=1 to enable them (see scripts/Makefile.extrawarn) > -KBUILD_CFLAGS += -Wno-unused-but-set-variable > - > # Warn about unmarked fall-throughs in switch statement. > # Disabled for clang while comment to attribute conversion happens and > # https://github.com/ClangBuiltLinux/linux/issues/636 is discussed. > KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough,) > endif > > +# These warnings generated too much noise in a regular build. > +# Use make W=1 to enable them (see scripts/Makefile.extrawarn) > +KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable) > + > KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable) > ifdef CONFIG_FRAME_POINTER > KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls > > base-commit: d8201efe75e13146ebde433745c7920e15593baf > -- > 2.31.1.362.g311531c9de > > -- -- Thanks, ~Nick Desaulniers