From: Nick Desaulniers <ndesaulniers@google.com>
To: alexandre.belloni@bootlin.com, a.zummo@towertech.it
Cc: linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] rtc: omap: Use define directive for PIN_CONFIG_ACTIVE_HIGH
Date: Mon, 12 Nov 2018 11:25:26 -0800 [thread overview]
Message-ID: <CAKwvOdm+Phwn7GdfVTf0UpBjShrN+vyfjhU3ctXqj3WBat9dVw@mail.gmail.com> (raw)
In-Reply-To: <20181101005502.9171-1-natechancellor@gmail.com>
On Wed, Oct 31, 2018 at 5:55 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when one enumerated type is implicitly converted to another:
>
> drivers/rtc/rtc-omap.c:574:21: warning: implicit conversion from
> enumeration type 'enum rtc_pin_config_param' to different enumeration
> type 'enum pin_config_param' [-Wenum-conversion]
> {"ti,active-high", PIN_CONFIG_ACTIVE_HIGH, 0},
> ~ ^~~~~~~~~~~~~~~~~~~~~~
> drivers/rtc/rtc-omap.c:579:12: warning: implicit conversion from
> enumeration type 'enum rtc_pin_config_param' to different enumeration
> type 'enum pin_config_param' [-Wenum-conversion]
> PCONFDUMP(PIN_CONFIG_ACTIVE_HIGH, "input active high", NULL, false),
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/pinctrl/pinconf-generic.h:163:11: note: expanded from
> macro 'PCONFDUMP'
> .param = a, .display = b, .format = c, .has_arg = d \
> ^
> 2 warnings generated.
>
> It is expected that pinctrl drivers can extend pin_config_param because
> of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
> isn't an issue. Most drivers that take advantage of this define the
> PIN_CONFIG variables as constants, rather than enumerated values. Do the
> same thing here so that Clang no longer warns.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/144
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/rtc/rtc-omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 320b4a520eb3..bbff0e2deb84 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -566,9 +566,7 @@ static const struct pinctrl_ops rtc_pinctrl_ops = {
> .dt_free_map = pinconf_generic_dt_free_map,
> };
>
> -enum rtc_pin_config_param {
> - PIN_CONFIG_ACTIVE_HIGH = PIN_CONFIG_END + 1,
> -};
> +#define PIN_CONFIG_ACTIVE_HIGH (PIN_CONFIG_END + 1)
>
> static const struct pinconf_generic_params rtc_params[] = {
> {"ti,active-high", PIN_CONFIG_ACTIVE_HIGH, 0},
> --
> 2.19.1
>
Bumping for review
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-11-12 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 0:55 [PATCH] rtc: omap: Use define directive for PIN_CONFIG_ACTIVE_HIGH Nathan Chancellor
2018-11-12 19:25 ` Nick Desaulniers [this message]
2018-11-12 22:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdm+Phwn7GdfVTf0UpBjShrN+vyfjhU3ctXqj3WBat9dVw@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).