From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437E4C433DB for ; Thu, 4 Feb 2021 19:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0CFF64F38 for ; Thu, 4 Feb 2021 19:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239748AbhBDTUU (ORCPT ); Thu, 4 Feb 2021 14:20:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238713AbhBDTTi (ORCPT ); Thu, 4 Feb 2021 14:19:38 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9D3C06178C for ; Thu, 4 Feb 2021 11:18:56 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id g15so2390946pjd.2 for ; Thu, 04 Feb 2021 11:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gpuC+d2FUOI/ZHg93wQH+r85JDI4pp/FX9Ub2W2auJA=; b=IeotN/9b8v5XKf4EhKYsx0kfJDGFixxFAbgIG7uuE5tnabLRIRh0tUk3+MzaseOpkO MGOfJLn/t0mNBWKilsOO0R1ZgJ6TjREJeV04mMuqVPU0OoeZfGS3dqy0VbE+EvvmXJgg ra34agXgJ5zd5/OLk3jfRChhcNS4ABtu9mHgG8ARfKSTgC/4vLvvrSay2qoLL3Gzr3Dd HAdmCEbXZErEAO0aPLwRJ+qLYZN2w7HXPO6aKm0qC4+1SK+wu7rNYvqDwzUbY9GsiJ51 NPYomZ2yLP+eL9f0GUvcJMzbF+QnmE0YujcWl0QGEnpL1s/uI3nJkw08iQvzzN3jBl/q xS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gpuC+d2FUOI/ZHg93wQH+r85JDI4pp/FX9Ub2W2auJA=; b=S4meZMErvYMHHhIMCpYS567SXOJtatc0nmzEZkb/+fJxJ4PEMnidhnBs0GMFEX9Nat kE7oSopDWqUGcgkk51j4R4CqqdYqmyGviML8b98gM6XKhzPJVl0vqE9QFx3jvZlKFy4f clsWe9fg3DZGLRmJ4Vq2XlXurtd25n+hk8T9dP8XHX28lYl4d6Px9iCEmfjktagGyYKo X5aluJZOs9GGQM+xEwh0kPo5ImxFgZArWzxo1js3QFEZm7cL5+xfpcCUwcOvWq+ACxZW ib2VJ41QHw1H2MqPi856RUOjOphDkNsBHHZ4053crEpnoTjeBGiN2tjRlqhjTjG5Ye/s 8mHQ== X-Gm-Message-State: AOAM532KF1+UvICZg8ZHIbzPTPn9SZNnClYrFmrMBiFCW7MO3u1RlFVk 08oQgWMi+iuO200fc6XpmJN5QyDRufkWpRFqAkcpBg== X-Google-Smtp-Source: ABdhPJzl7LAFaClTjRx4s2bi9MKyf3s0L375hLNeyyqodeJV4B0xlBdb5b8nigoIhDlFSEWostsGA+rxdrWqOWCmz5U= X-Received: by 2002:a17:90a:bf10:: with SMTP id c16mr435444pjs.101.1612466335618; Thu, 04 Feb 2021 11:18:55 -0800 (PST) MIME-Version: 1.0 References: <20210130004401.2528717-1-ndesaulniers@google.com> <20210130004401.2528717-2-ndesaulniers@google.com> <20210204103946.GA14802@wildebeest.org> In-Reply-To: <20210204103946.GA14802@wildebeest.org> From: Nick Desaulniers Date: Thu, 4 Feb 2021 11:18:44 -0800 Message-ID: Subject: Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice To: Mark Wielaard Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Sedat Dilek , LKML , clang-built-linux , Linux Kbuild mailing list , linux-arch , Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > Hi Nick, > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs, and makes adding future versions more straightforward. > > > > GCC since ~4.8 has defaulted to this DWARF version implicitly. > > And since GCC 11 it defaults to DWARF version 5. > > It would be better to set the default to the DWARF version that the > compiler generates. So if the user doesn't select any version then it > should default to just -g (or -gdwarf). I disagree. https://lore.kernel.org/lkml/CAKwvOdk0zxewEOaFuqK0aSMz3vKNzDOgmez=-Dae4+bodsSg5w@mail.gmail.com/ """ I agree that this patch takes away the compiler vendor's choice as to what the implicit default choice is for dwarf version for the kernel. (We, the Linux kernel, do so already for implicit default -std=gnuc* as well). ... But I'm going to suggest we follow the Zen of Python: explicit is better than implicit. """ We have a number of in tree and out of tree DWARF consumers that aren't ready for DWARF v5. Kernel developers need a way to disable DWARF v5 until their dependencies are deployed or more widely available. I'm happy to consider eventually moving the default DWARF version for the kernel to v5, and ideas for how to wean developers off of v4, but I don't think forcing v5 on kernel developers right now is the most delicate approach. -- Thanks, ~Nick Desaulniers