linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: Greg Hackmann <ghackmann@android.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-team@android.com,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Tri Vo <trong@android.com>
Subject: Re: [PATCH v3 0/3] gcov: add Clang support
Date: Wed, 6 Feb 2019 16:52:58 -0800	[thread overview]
Message-ID: <CAKwvOdm1+P-8YqtgZV65EAMnVN-n1mkpOOX0yp-qEbuCH5F9Rw@mail.gmail.com> (raw)
In-Reply-To: <20190122233749.42220-1-trong@android.com>

On Tue, Jan 22, 2019 at 3:38 PM Tri Vo <trong@android.com> wrote:
>
> This patch series adds Clang supoprt for gcov.
>
> Patch 1 refactors existing code in preparation for Clang support.
> Patch 2 implements necessary LLVM runtime hooks and gcov kernel interfaces.
> Patch 3 updates documentation.
>
> Greg Hackmann (2):
>   gcov: Clang: move common GCC code into gcc_base.c
>   gcov: Clang support
>
> Tri Vo (1):
>   gcov: docs: add a note on GCC vs Clang differences
>
>  Documentation/dev-tools/gcov.rst |  18 +-
>  kernel/gcov/Kconfig              |   3 +-
>  kernel/gcov/Makefile             |   5 +-
>  kernel/gcov/base.c               |  84 +----
>  kernel/gcov/clang.c              | 555 +++++++++++++++++++++++++++++++
>  kernel/gcov/gcc_base.c           |  86 +++++
>  kernel/gcov/gcov.h               |   3 +
>  7 files changed, 665 insertions(+), 89 deletions(-)
>  create mode 100644 kernel/gcov/clang.c
>  create mode 100644 kernel/gcov/gcc_base.c
>
> v2:
> - Reorganized config dependencies, as per Masahiro.
>
> v3:
> - Squashed patches 2-4 of v2, as per Nick, Masahiro, and Peter.
> Addressed comments by Peter:
> - Moved __gcov_exit() to gcc_base.c
> - Added missing header to gcc_base.c
> - Removed unnecessary boundary checks in gcov_info_add().
> - Changed counters' allocation to use vmalloc().
> - Added check for failed allocation of filename.
> - Changed list_for_each_entry_safe to list_for_each_entry when traversing
>   without modifying.
> - Updated Documentation/dev-tools/gcov.rst
>
> --
> 2.20.1.321.g9e740568ce-goog
>

Bumping this thread for review.

-- 
Thanks,
~Nick Desaulniers

  parent reply	other threads:[~2019-02-07  0:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 23:37 [PATCH v3 0/3] gcov: add Clang support Tri Vo
2019-01-22 23:37 ` [PATCH v3 1/3] gcov: Clang: move common GCC code into gcc_base.c Tri Vo
2019-03-05 13:40   ` Peter Oberparleiter
2019-01-22 23:37 ` [PATCH v3 2/3] gcov: Clang support Tri Vo
2019-03-05 13:57   ` Peter Oberparleiter
2019-01-22 23:37 ` [PATCH v3 3/3] gcov: docs: add a note on GCC vs Clang differences Tri Vo
2019-01-22 23:50   ` Nick Desaulniers
2019-03-05 14:07   ` Peter Oberparleiter
2019-02-07  0:52 ` Nick Desaulniers [this message]
2019-02-22  0:57   ` [PATCH v3 0/3] gcov: add Clang support Nick Desaulniers
2019-03-05 14:29 ` Peter Oberparleiter
2019-03-12  4:57   ` Tri Vo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdm1+P-8YqtgZV65EAMnVN-n1mkpOOX0yp-qEbuCH5F9Rw@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=ghackmann@android.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    --cc=trong@android.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).