From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Allison Randal <allison@lohutok.net>,
Armijn Hemel <armijn@tjaldur.nl>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ingo Molnar <mingo@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Song Liu <songliubraving@fb.com>,
Zhengyuan Liu <liuzhengyuan@kylinos.cn>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/7] x86: remove always-defined CONFIG_AS_* options
Date: Mon, 23 Mar 2020 12:45:56 -0700 [thread overview]
Message-ID: <CAKwvOdm1B=Wc6zcxpapcbeReX0_2V3AiqxGUgikL4ypztZkUEg@mail.gmail.com> (raw)
In-Reply-To: <20200323020844.17064-1-masahiroy@kernel.org>
On Sun, Mar 22, 2020 at 7:09 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> arch/x86/Makefile tests instruction code by $(call as-instr, ...)
>
> Some of them are very old.
> For example, the check for CONFIG_AS_CFI dates back to 2006.
>
> We raise GCC versions from time to time, and we clean old code away.
> The same policy applied to binutils.
>
> The current minimal supported version of binutils is 2.21
>
> This is new enough to recognize the instruction in most of
> as-instr calls.
I'm quite happy to see this series; a few weekends ago I was playing
around with adding dwarf-5 support to the Linux kernel, and was
looking at these noticing there was quite a bit of cruft.
Unfortunately, I got detoured filing bugs against GNU as for dwarf-5
bugs, but the developers were very responsive and fixed them all. I
should go find and dust off that patchset. In the meantime, I'll try
to help review these patches. Thank you for sending them.
>
>
>
> Masahiro Yamada (7):
> x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h
> x86: remove always-defined CONFIG_AS_CFI
> x86: remove always-defined CONFIG_AS_CFI_SIGNAL_FRAME
> x86: remove always-defined CONFIG_AS_CFI_SECTIONS
> x86: remove always-defined CONFIG_AS_SSSE3
> x86: remove always-defined CONFIG_AS_AVX
> x86: add comments about the binutils version to support code in
> as-instr
>
> arch/x86/Makefile | 21 +++------
> arch/x86/crypto/Makefile | 32 ++++++--------
> arch/x86/crypto/aesni-intel_avx-x86_64.S | 3 --
> arch/x86/crypto/aesni-intel_glue.c | 14 +-----
> arch/x86/crypto/blake2s-core.S | 2 -
> arch/x86/crypto/poly1305-x86_64-cryptogams.pl | 8 ----
> arch/x86/crypto/poly1305_glue.c | 6 +--
> arch/x86/crypto/sha1_ssse3_asm.S | 4 --
> arch/x86/crypto/sha1_ssse3_glue.c | 9 +---
> arch/x86/crypto/sha256-avx-asm.S | 3 --
> arch/x86/crypto/sha256_ssse3_glue.c | 8 +---
> arch/x86/crypto/sha512-avx-asm.S | 2 -
> arch/x86/crypto/sha512_ssse3_glue.c | 7 +--
> arch/x86/include/asm/dwarf2.h | 43 -------------------
> arch/x86/include/asm/xor_avx.h | 9 ----
> lib/raid6/algos.c | 2 -
> lib/raid6/recov_ssse3.c | 6 ---
> lib/raid6/test/Makefile | 3 --
> 18 files changed, 26 insertions(+), 156 deletions(-)
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200323020844.17064-1-masahiroy%40kernel.org.
--
Thanks,
~Nick Desaulniers
prev parent reply other threads:[~2020-03-23 19:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 2:08 [PATCH 0/7] x86: remove always-defined CONFIG_AS_* options Masahiro Yamada
2020-03-23 2:08 ` [PATCH 1/7] x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h Masahiro Yamada
2020-03-23 2:08 ` [PATCH 2/7] x86: remove always-defined CONFIG_AS_CFI Masahiro Yamada
2020-03-23 20:37 ` Nick Desaulniers
2020-03-23 2:08 ` [PATCH 3/7] x86: remove always-defined CONFIG_AS_CFI_SIGNAL_FRAME Masahiro Yamada
2020-03-23 20:45 ` Nick Desaulniers
2020-03-23 2:08 ` [PATCH 4/7] x86: remove always-defined CONFIG_AS_CFI_SECTIONS Masahiro Yamada
2020-03-23 20:59 ` Nick Desaulniers
2020-03-23 2:08 ` [PATCH 5/7] x86: remove always-defined CONFIG_AS_SSSE3 Masahiro Yamada
2020-03-23 18:06 ` Jason A. Donenfeld
2020-03-23 20:44 ` Masahiro Yamada
2020-03-23 20:48 ` Jason A. Donenfeld
2020-03-23 21:01 ` Jason A. Donenfeld
2020-03-23 2:08 ` [PATCH 6/7] x86: remove always-defined CONFIG_AS_AVX Masahiro Yamada
2020-03-23 2:08 ` [PATCH 7/7] x86: add comments about the binutils version to support code in as-instr Masahiro Yamada
2020-03-23 4:07 ` [PATCH 0/7] x86: remove always-defined CONFIG_AS_* options Jason A. Donenfeld
2020-03-23 4:28 ` Jason A. Donenfeld
2020-03-23 6:35 ` Masahiro Yamada
2020-03-23 6:53 ` Jason A. Donenfeld
2020-03-23 9:52 ` Sedat Dilek
2020-03-23 19:50 ` Jason A. Donenfeld
2020-03-24 8:46 ` Sedat Dilek
2020-03-23 22:03 ` Masahiro Yamada
2020-03-23 22:10 ` Jason A. Donenfeld
2020-03-23 19:45 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdm1B=Wc6zcxpapcbeReX0_2V3AiqxGUgikL4ypztZkUEg@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=Jason@zx2c4.com \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhengyuan@kylinos.cn \
--cc=masahiroy@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).