From: Nick Desaulniers <ndesaulniers@google.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Borislav Petkov <bp@suse.de>,
Eric Dumazet <eric.dumazet@gmail.com>,
Juergen Gross <jgross@suse.com>, Jian Cai <jiancai@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Michael Ellerman <mpe@ellerman.id.au>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Huang Ying <ying.huang@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] smp: fix smp_call_function_single_async prototype
Date: Thu, 29 Apr 2021 11:39:03 -0700 [thread overview]
Message-ID: <CAKwvOdmEybM=Vij+DP0O8waL4Awi1pip2VzHhcczgNQsryqBoA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1S0ct832wN0aM8ZAKbbQ3=w2_vSprhzQ4rLN=Ue=L0JQ@mail.gmail.com>
On Thu, Apr 29, 2021 at 11:27 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> Either way, I'll give it some more time on the randconfig build machine
> before I send out v2.
SGTM and thanks for the fix. Perhaps worth a note that this isn't
just "a violation of the calling conventions" but straight up
undefined behavior, full stop.
UBSAN folks are working on adding a catch for this as well:
https://reviews.llvm.org/D100037, see the relevant citations from the
standard.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-04-29 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 15:09 [PATCH] smp: fix smp_call_function_single_async prototype Arnd Bergmann
2021-04-29 15:54 ` Jens Axboe
2021-04-29 18:17 ` Nick Desaulniers
2021-04-29 18:24 ` Nick Desaulniers
2021-04-29 18:26 ` Arnd Bergmann
2021-04-29 18:39 ` Nick Desaulniers [this message]
2021-04-29 19:08 ` kernel test robot
2021-04-29 21:44 ` kernel test robot
2021-04-29 23:00 ` Jian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdmEybM=Vij+DP0O8waL4Awi1pip2VzHhcczgNQsryqBoA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=arnd@kernel.org \
--cc=axboe@kernel.dk \
--cc=bp@suse.de \
--cc=clang-built-linux@googlegroups.com \
--cc=eric.dumazet@gmail.com \
--cc=jgross@suse.com \
--cc=jiancai@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).