From: Nick Desaulniers <ndesaulniers@google.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dmitry Golovin <dima@golovin.in>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH] x86/unwind/orc: Fix ORC unwind table alignment
Date: Wed, 6 Mar 2019 10:44:01 -0800 [thread overview]
Message-ID: <CAKwvOdmHe-bkt34E5yf81GoiFRHR8EPnu8wqk2aD2u8P_4Q5jQ@mail.gmail.com> (raw)
In-Reply-To: <d55027ee95fe73e952dcd8be90aebd31b0095c45.1551892041.git.jpoimboe@redhat.com>
On Wed, Mar 6, 2019 at 9:08 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> The .orc_unwind section is a packed array of 6-byte structs. It's
> currently aligned to 6 bytes, which is causing warnings in the LLD
> linker.
>
> Six isn't a power of two, so it's not a valid alignment value. The
> actual alignment doesn't matter much because it's an array of packed
> structs. An alignment of two is sufficient. In reality it always gets
> aligned to four bytes because it comes immediately after the
> 4-byte-aligned .orc_unwind_ip section.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/218
> Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Thanks for the patch Josh, we appreciate it. It looks like
ee9f8fce9964 landed in v4.14-rc1. Should we CC stable?
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Reported-by: Dmitry Golovin <dima@golovin.in>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> include/asm-generic/vmlinux.lds.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 3d7a6a9c2370..f8f6f04c4453 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -733,7 +733,7 @@
> KEEP(*(.orc_unwind_ip)) \
> __stop_orc_unwind_ip = .; \
> } \
> - . = ALIGN(6); \
> + . = ALIGN(2); \
> .orc_unwind : AT(ADDR(.orc_unwind) - LOAD_OFFSET) { \
> __start_orc_unwind = .; \
> KEEP(*(.orc_unwind)) \
> --
> 2.17.2
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-03-06 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 17:07 [PATCH] x86/unwind/orc: Fix ORC unwind table alignment Josh Poimboeuf
2019-03-06 18:44 ` Nick Desaulniers [this message]
2019-03-06 19:04 ` Josh Poimboeuf
2019-03-06 19:40 ` [tip:x86/urgent] " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdmHe-bkt34E5yf81GoiFRHR8EPnu8wqk2aD2u8P_4Q5jQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=dima@golovin.in \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).