linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: asmadeus@codewreck.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	joe@perches.com, Jonathan Corbet <corbet@lwn.net>,
	Arnd Bergmann <arnd@arndb.de>,
	dwmw@amazon.co.uk, LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] compiler-gcc: get back Clang build
Date: Tue, 21 Aug 2018 09:32:24 -0700	[thread overview]
Message-ID: <CAKwvOdmLQen+TWF_F3e5-66vtF3FEnoxjEgZbjmOZ9cv6YrEpA@mail.gmail.com> (raw)
In-Reply-To: <20180821123832.GA19034@nautica>

On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet
<asmadeus@codewreck.org> wrote:
>
> Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC:
> > Thanks for noticing, and sending this patch.  I'm happy to see others
> > testing with Clang.  I noticed this too near the end of the day
> > https://github.com/ClangBuiltLinux/linux/issues/27.
>
> FWIW libbcc so many BPF users also use clang, so this has more impact
> than just testing to build linux with clang (not that this would be any
> reason to delay fixing either way)
>
> I would tend to agree havin a compiler-common + make clang/intel not
> include compiler-gcc would probably be best in the long run but we might
> want a quick fix for 4.19 meanwhile..

That's fair. SOP here is quick (full) revert, then come up with a
better fix.  And I do prefer Masahiro's partial revert to a full
revert of Joe's patch.  That will give us more time to develop the
proper fix rather than rush.  I'll try to see how we can more properly
split the compiler specific headers.

Tested with gcc-7 and clang-8.

Tested-by: Nick Desaulniers <ndesaulniers@google.com>
-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2018-08-21 16:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21  6:48 [PATCH] compiler-gcc: get back Clang build Masahiro Yamada
2018-08-21  8:09 ` Nick Desaulniers
2018-08-21 10:39 ` Joe Perches
2018-08-21 16:35   ` Nick Desaulniers
2018-08-21 17:13   ` Masahiro Yamada
2018-08-21 17:20     ` Joe Perches
2018-08-21 12:38 ` Dominique Martinet
2018-08-21 16:32   ` Nick Desaulniers [this message]
2018-08-21 16:45     ` Joe Perches
2018-08-21 17:00       ` Nick Desaulniers
2018-08-22  4:16         ` Dominique Martinet
2018-08-22  4:22           ` Joe Perches
2018-08-22  4:32             ` Dominique Martinet
2018-08-22 18:31               ` Nick Desaulniers
2018-08-22 19:01                 ` Nick Desaulniers
2018-08-22 20:50                 ` Joe Perches
2018-08-22 23:05                   ` Nick Desaulniers
2018-08-22 23:32                     ` Joe Perches
2018-08-22 23:57                 ` Dominique Martinet
2018-08-21 16:33 ` Joe Perches
2018-08-21 16:57   ` Nick Desaulniers
2018-08-21 17:22     ` Joe Perches
2018-08-21 17:07   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdmLQen+TWF_F3e5-66vtF3FEnoxjEgZbjmOZ9cv6YrEpA@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=asmadeus@codewreck.org \
    --cc=corbet@lwn.net \
    --cc=dwmw@amazon.co.uk \
    --cc=geert@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).