From: Nick Desaulniers <ndesaulniers@google.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>,
Nathan Chancellor <natechancellor@gmail.com>,
clang-built-linux@googlegroups.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcov: clang: rectify gcov_info_add's kernel-doc
Date: Wed, 14 Jul 2021 12:47:01 -0700 [thread overview]
Message-ID: <CAKwvOdn0DPA2sk8MtmVa9shWDH7GL4t2X5K0V4T=+RnpUKJGOw@mail.gmail.com> (raw)
In-Reply-To: <20210702044950.10411-1-lukas.bulwahn@gmail.com>
On Thu, Jul 1, 2021 at 9:50 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> For gcov_info_add, ./scripts/kernel-doc -none kernel/gcov/clang.c warns:
>
> warning: Function parameter or member 'dst' not described in 'gcov_info_add'
> warning: Function parameter or member 'src' not described in 'gcov_info_add'
> warning: Excess function parameter 'dest' description in 'gcov_info_add'
> warning: Excess function parameter 'source' description in 'gcov_info_add'
>
> Obviously, the kernel-doc's and function's parameter names slightly mismatch.
>
> Adjust the kernel-doc description to make kernel-doc happy.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks Lukas!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> kernel/gcov/clang.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c
> index cbb0bed958ab..214696e28ec1 100644
> --- a/kernel/gcov/clang.c
> +++ b/kernel/gcov/clang.c
> @@ -264,10 +264,10 @@ int gcov_info_is_compatible(struct gcov_info *info1, struct gcov_info *info2)
>
> /**
> * gcov_info_add - add up profiling data
> - * @dest: profiling data set to which data is added
> - * @source: profiling data set which is added
> + * @dst: profiling data set to which data is added
> + * @src: profiling data set which is added
> *
> - * Adds profiling counts of @source to @dest.
> + * Adds profiling counts of @src to @dst.
> */
> void gcov_info_add(struct gcov_info *dst, struct gcov_info *src)
> {
> --
> 2.17.1
>
--
Thanks,
~Nick Desaulniers
prev parent reply other threads:[~2021-07-14 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 4:49 [PATCH] gcov: clang: rectify gcov_info_add's kernel-doc Lukas Bulwahn
2021-07-14 19:47 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdn0DPA2sk8MtmVa9shWDH7GL4t2X5K0V4T=+RnpUKJGOw@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=natechancellor@gmail.com \
--cc=oberpar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).