From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stefan Agner <stefan@agner.ch>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Chris Fries <cfries@google.com>,
joel@jms.id.au, dja@axtens.net,
Michal Marek <michal.lkml@markovi.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: consolidate Clang compiler flags
Date: Mon, 5 Nov 2018 09:59:09 -0800 [thread overview]
Message-ID: <CAKwvOdn1Shqc3nW6z0Ji_=4uMrOimhUbX3TRG7fQuysja64zog@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAT3ftcuNDfEhecMnfjG0Fkkh42wR7XQ1R9Tkr9OMrzAng@mail.gmail.com>
On Mon, Nov 5, 2018 at 1:19 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Mon, Nov 5, 2018 at 6:10 PM Stefan Agner <stefan@agner.ch> wrote:
> >
> > On 05.11.2018 03:48, Masahiro Yamada wrote:
> > > Add basic options for Clang such as --target, --prefix, --gcc-toolchain,
> > > -no-integrated-as to a single variable CLANG_FLAGS.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > ---
> > >
> > > Makefile | 13 ++++++-------
> > > 1 file changed, 6 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 93315eb..58c838a 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -487,18 +487,17 @@ endif
> > >
> > > ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> > > ifneq ($(CROSS_COMPILE),)
> > > -CLANG_TARGET := --target=$(notdir $(CROSS_COMPILE:%-=%))
> > > +CLANG_FLAGS = --target=$(notdir $(CROSS_COMPILE:%-=%))
> > > GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD)))
> > > -CLANG_PREFIX := --prefix=$(GCC_TOOLCHAIN_DIR)
> > > +CLANG_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)
> >
> > So this will expand later now, is this ok?
> >
> > --
> > Stefan
> >
> > > GCC_TOOLCHAIN := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
> > > endif
> > > ifneq ($(GCC_TOOLCHAIN),)
> > > -CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN)
> > > +CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN)
> > > endif
> > > -KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
> > > -KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
> > > -KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
> > > -KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
> > > +CLANG_FLAGS += $(call cc-option, -no-integrated-as)
> > > +KBUILD_CFLAGS += $(CLANG_FLAGS)
> > > +KBUILD_AFLAGS += $(CLANG_FLAGS)
>
>
> CLANG_FLAGS is expanded here because KBUILD_CFLAGS and KBUILD_AFLAGS
> are defined by using :=
>
> So, it should be OK, but turning CLANG_FLAGS into a simple variable
> will be a little more efficient since $(call cc-option, -no-integrated-as)
> is evaluated just once.
>
> (Or, this cc-option may not be necessary any longer.)
>
> Will send v2.
If the ultimate goal is not evaluate cc-option more than once,
removing cc-option from both KBUILD_CFLAGS and KBUILD_AFLAGS for clang
is the better approach; we always want those for clang
unconditionally. And if you by chance have an ancient version of clang
that doesn't support those flags, you wont be able to compile a kernel
anyways. Eventually we want to get Clang's integrated assembler in
shape to be used to assemble the kernel, but I think we're a ways off
there still.
--
Thanks,
~Nick Desaulniers
prev parent reply other threads:[~2018-11-05 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 2:48 [PATCH] kbuild: consolidate Clang compiler flags Masahiro Yamada
2018-11-05 9:09 ` Stefan Agner
2018-11-05 9:18 ` Masahiro Yamada
2018-11-05 17:59 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdn1Shqc3nW6z0Ji_=4uMrOimhUbX3TRG7fQuysja64zog@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=cfries@google.com \
--cc=dja@axtens.net \
--cc=joel@jms.id.au \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mka@chromium.org \
--cc=stefan@agner.ch \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).