From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74747C43381 for ; Thu, 7 Mar 2019 18:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 477772085A for ; Thu, 7 Mar 2019 18:32:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BlwaShHM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbfCGScH (ORCPT ); Thu, 7 Mar 2019 13:32:07 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44355 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGScH (ORCPT ); Thu, 7 Mar 2019 13:32:07 -0500 Received: by mail-pg1-f193.google.com with SMTP id j3so11914227pgm.11 for ; Thu, 07 Mar 2019 10:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2GV9H2NQZDiYEZ2Q74G2zL9ZSsg7QJ5o+oisANRjH9c=; b=BlwaShHM5TSDoUGlDQsOcFHCBRrqkEM93gacCQsJdlo2Z8IHrGiHgGSa4URLLdIl7p nZkZNg9A4IOjA9lQ2wwPNIsjAUlfUKSE6kxYhdGFX6bH9NKcIMnn9IPxNZ7HO1ghVXA1 51eiO3y58HIWGTTrt3gLMvZHo0hLpBcR8oIR+2+SE/60DgRIw2yuPzGWp/+qfqYf5p+l yKUmPplHh8FCFCCqk5hKLN2zfmt4CSela6mm07wwgjfZ8PzYEp2S6KRcWxWum+3SVf8g 0mvlrcfHKY4/9lPolnalVc2H57iwvScO75g7LJ166VMvSOzQqE0G51ElGNh/g1udK6Vc W4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2GV9H2NQZDiYEZ2Q74G2zL9ZSsg7QJ5o+oisANRjH9c=; b=MuJkF/h5e7qQn/X0m7gOnWEAQ6agMjhbgyw4w+rIq7UQ7lRiap/PZumPEEdGMPmDLl mOrjUCj5MlTSIDl/UFyV32Tqbw5NAUSCayQZ7SaeHkDzDLgaNGWhcureEW/hahgt0M29 RKHaBFvMVIMoFVQzxyrynFEus3CtkzhcfPoJMQtMSCsFkpgj98UDlJH5cWLQhauYcfAp Tzk4p+4Yu5Ts1RDBicE2OtlWtXQgY68UH5YNwnRXRCBNVODC+9JpIrhDXc1/Tbv4oLE1 dgrxrPR2PXSYUDddoyMXmHWWlblWc/4dJVqqjiqfAlBp1YEBoK2wzGigbWy1u0pO415c Bdsw== X-Gm-Message-State: APjAAAX2KuysSWKUQ7FB9yXBioDnRI06s6bla7Aa44nJH6voDG+gb84A fu85Qh0Zyvv+jBMsPwARnjbfwFvec5h+rsHkjTQGYA== X-Google-Smtp-Source: APXvYqy1GJ+ErVJrILCqHpdsa1dKNd+lAn/tJSdirwDHMCJtq5kHwEBfOCXF+Z/nJG3WtQop4dLwdEMtZuN2/SsdTP8= X-Received: by 2002:a63:c70c:: with SMTP id n12mr12849683pgg.302.1551983526038; Thu, 07 Mar 2019 10:32:06 -0800 (PST) MIME-Version: 1.0 References: <20190307171604.27791-1-natechancellor@gmail.com> In-Reply-To: <20190307171604.27791-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Thu, 7 Mar 2019 10:31:55 -0800 Message-ID: Subject: Re: [PATCH] iio: adc: stmpe-adc: Shuffle an if statement around in stmpe_adc_isr To: Nathan Chancellor Cc: Jonathan Cameron , Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Maxime Coquelin , Alexandre Torgue , Stefan Agner , Max Krummenacher , Philippe Schenker , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linux ARM , LKML , clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 7, 2019 at 9:16 AM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/iio/adc/stmpe-adc.c:204:13: warning: variable 'data' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > > Clang can't tell that data will never be used uninitialized because the > two if statements take care of all cases. Remove the first if statement > and make it the else branch of the second one so that it is apparent to > Clang that all cases are covered. > > Link: https://github.com/ClangBuiltLinux/linux/issues/387 > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor LGTM, thanks Nathan. Reviewed-by: NIck Desaulniers > --- > drivers/iio/adc/stmpe-adc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c > index 37f4b74a5d32..7921f827c6ec 100644 > --- a/drivers/iio/adc/stmpe-adc.c > +++ b/drivers/iio/adc/stmpe-adc.c > @@ -184,9 +184,6 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id) > struct stmpe_adc *info = (struct stmpe_adc *)dev_id; > u16 data; > > - if (info->channel > STMPE_TEMP_CHANNEL) > - return IRQ_NONE; > - > if (info->channel <= STMPE_ADC_LAST_NR) { > int int_sta; > > @@ -205,6 +202,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id) > /* Read value */ > stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2, > (u8 *) &data); > + } else { > + return IRQ_NONE; > } > > info->value = (u32) be16_to_cpu(data); > -- > 2.21.0 > -- Thanks, ~Nick Desaulniers