From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: faisal.latif@intel.com, dledford@redhat.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IB/nes: Remove unnecessary parentheses
Date: Thu, 20 Sep 2018 09:47:45 -0700 [thread overview]
Message-ID: <CAKwvOdnB32mZ900adeMmBpXTa6LjzAOooaGS+w96vkjZR=G_HQ@mail.gmail.com> (raw)
In-Reply-To: <20180920032956.14360-1-natechancellor@gmail.com>
On Wed, Sep 19, 2018 at 8:30 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when more than one set of parentheses are used in single
> conditional statements.
>
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> } while ((temp_phy_data2 == temp_phy_data));
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: note: remove extraneous
> parentheses around the comparison to silence this warning
> } while ((temp_phy_data2 == temp_phy_data));
> ~ ^ ~
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: note: use '=' to turn this
> equality comparison into an assignment
> } while ((temp_phy_data2 == temp_phy_data));
> ^~
> =
>
> Remove the unnecessary parentheses to silence this warning.
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/infiniband/hw/nes/nes_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
> index bd0675d8f298..5517e392bc01 100644
> --- a/drivers/infiniband/hw/nes/nes_hw.c
> +++ b/drivers/infiniband/hw/nes/nes_hw.c
> @@ -1443,7 +1443,7 @@ static int nes_init_2025_phy(struct nes_device *nesdev, u8 phy_type, u8 phy_inde
> mdelay(1);
> nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
> temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
> - } while ((temp_phy_data2 == temp_phy_data));
> + } while (temp_phy_data2 == temp_phy_data);
>
> /* wait for tracking */
> counter = 0;
> --
> 2.19.0
>
Nathan, thanks for this patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-09-20 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 3:29 [PATCH] IB/nes: Remove unnecessary parentheses Nathan Chancellor
2018-09-20 16:47 ` Nick Desaulniers [this message]
2018-09-21 16:04 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnB32mZ900adeMmBpXTa6LjzAOooaGS+w96vkjZR=G_HQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).