From: Nick Desaulniers <ndesaulniers@google.com>
To: Rob Simmons <rsimmons514@gmail.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Will Deacon <will@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: a bug in genksysms/CONFIG_MODVERSIONS w/ __attribute__((foo))?
Date: Mon, 27 Jul 2020 11:03:19 -0700 [thread overview]
Message-ID: <CAKwvOdnK7+iUyBdBaVTY=5JMK9Fm11PU2sc8ZwYfWs1OYAbeNQ@mail.gmail.com> (raw)
In-Reply-To: <CAOGTHR7wWaS+CdA9aR-8wWXa-AC47WBuLe5BEg01pFoKwKBpAw@mail.gmail.com>
On Sun, Jul 26, 2020 at 4:31 PM Rob Simmons <rsimmons514@gmail.com> wrote:
You may have forgotten to send a body; but yes genksysms is brittle
and upstream development on it stopped years ago. Put an attribute
someplace unexpected and the parser will silently fail, making the
modversions hash all zeros, which doesn't protect you from loading a
potentially harmful module with different function signature. If
you're planning on attending plumbers, I plan to put together a brief
talk on the subject.
--
Thanks,
~Nick Desaulniers
next parent reply other threads:[~2020-07-27 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOGTHR7wWaS+CdA9aR-8wWXa-AC47WBuLe5BEg01pFoKwKBpAw@mail.gmail.com>
2020-07-27 18:03 ` Nick Desaulniers [this message]
2019-08-26 21:22 a bug in genksysms/CONFIG_MODVERSIONS w/ __attribute__((foo))? Nick Desaulniers
2019-08-26 22:57 ` Nick Desaulniers
2019-08-27 9:58 ` Nicholas Piggin
2019-08-27 10:49 ` Masahiro Yamada
2019-08-27 12:42 ` Nicholas Piggin
2019-08-27 15:34 ` Ben Hutchings
2019-08-27 17:09 ` Greg KH
2019-08-27 21:11 ` Ben Hutchings
2019-08-28 2:25 ` Nicholas Piggin
2019-08-28 17:17 ` Nick Desaulniers
2019-08-28 21:42 ` Matthias Maennich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnK7+iUyBdBaVTY=5JMK9Fm11PU2sc8ZwYfWs1OYAbeNQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rsimmons514@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).