From: Nick Desaulniers <ndesaulniers@google.com>
To: Arnd Bergmann <arnd@arndb.de>, "S, Shirish" <sshankar@amd.com>
Cc: "Wentland, Harry" <Harry.Wentland@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"yshuiv7@gmail.com" <yshuiv7@gmail.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Matthias Kaehlcke <mka@google.com>,
"S, Shirish" <Shirish.S@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: AMDGPU and 16B stack alignment
Date: Tue, 15 Oct 2019 11:05:56 -0700 [thread overview]
Message-ID: <CAKwvOdnLxm_tZ_qR1D-BE64Z3QaMC2h79ooobdRVAzmCD_2_Sg@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3_Q15hKT=gyupb0FrPX1xV3tEBpVaYy1LF0kMUj2u8hw@mail.gmail.com>
On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Oct 15, 2019 at 9:08 AM S, Shirish <sshankar@amd.com> wrote:
> > On 10/15/2019 3:52 AM, Nick Desaulniers wrote:
>
> > My gcc build fails with below errors:
> >
> > dcn_calcs.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12
> >
> > dcn_calc_math.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12
I was able to reproduce this failure on pre-7.1 versions of GCC. It
seems that when:
1. code is using doubles
2. setting -mpreferred-stack-boundary=3 -mno-sse2, ie. 8B stack alignment
than GCC produces that error:
https://godbolt.org/z/7T8nbH
That's already a tall order of constraints, so it's understandable
that the compiler would just error likely during instruction
selection, but was eventually taught how to solve such constraints.
> >
> > While GPF observed on clang builds seem to be fixed.
Thanks for the report. Your testing these patches is invaluable, Shirish!
>
> Ok, so it seems that gcc insists on having at least 2^4 bytes stack
> alignment when
> SSE is enabled on x86-64, but does not actually rely on that for
> correct operation
> unless it's using sse2. So -msse always has to be paired with
> -mpreferred-stack-boundary=3.
Seemingly only for older versions of GCC, pre 7.1.
>
> For clang, it sounds like the opposite is true: when passing 16 byte
> stack alignment
> and having sse/sse2 enabled, it requires the incoming stack to be 16
> byte aligned,
I don't think it requires the incoming stack to be 16B aligned for
sse2, I think it requires the incoming and current stack alignment to
match. Today it does not, which is why we observe GPFs.
> but passing 8 byte alignment makes it do the right thing.
>
> So, should we just always pass $(call cc-option, -mpreferred-stack-boundary=4)
> to get the desired outcome on both?
Hmmm...I would have liked to remove it outright, as it is an ABI
mismatch that is likely to result in instability and non-fun-to-debug
runtime issues in the future. I suspect my patch does work for GCC
7.1+. The question is: Do we want to either:
1. mark AMDGPU broken for GCC < 7.1, or
2. continue supporting it via stack alignment mismatch?
2 is brittle, and may break at any point in the future, but if it's
working for someone it does make me feel bad to outright disable it.
What I'd image 2 looks like is (psuedo code in a Makefile):
if CC_IS_GCC && GCC_VERSION < 7.1:
set stack alignment to 16B and hope for the best
So my diff would be amended to keep the stack alignment flags, but
only to support GCC < 7.1. And that assumes my change compiles with
GCC 7.1+. (Looks like it does for me locally with GCC 8.3, but I would
feel even more confident if someone with hardware to test on and GCC
7.1+ could boot test).
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-10-15 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 22:22 AMDGPU and 16B stack alignment Nick Desaulniers
[not found] ` <9e4d6378-5032-8521-13a9-d9d9519d07de@amd.com>
2019-10-15 7:19 ` Arnd Bergmann
2019-10-15 10:48 ` David Laight
2019-10-15 18:05 ` Nick Desaulniers [this message]
2019-10-15 18:11 ` Nick Desaulniers
2019-10-15 18:30 ` Alex Deucher
2019-10-15 20:15 ` Nick Desaulniers
2019-10-15 20:26 ` Arvind Sankar
2019-10-16 1:51 ` Nick Desaulniers
2019-10-16 18:55 ` Arvind Sankar
2019-10-16 23:05 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdnLxm_tZ_qR1D-BE64Z3QaMC2h79ooobdRVAzmCD_2_Sg@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Shirish.S@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrew.cooper3@citrix.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@google.com \
--cc=sshankar@amd.com \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).