From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2682C2D0EC for ; Tue, 7 Apr 2020 19:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97F592082F for ; Tue, 7 Apr 2020 19:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CQE9Dcfh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbgDGT5g (ORCPT ); Tue, 7 Apr 2020 15:57:36 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35892 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726884AbgDGT5f (ORCPT ); Tue, 7 Apr 2020 15:57:35 -0400 Received: by mail-pf1-f196.google.com with SMTP id n10so1298138pff.3 for ; Tue, 07 Apr 2020 12:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=v/v3EOCeKlH1yy1lBBdbnJgt8NXsE7ukja0JvSrCQjQ=; b=CQE9Dcfhusx6FQIpv2B+gU7vG9dGA9oCh6IUgcsC12yvUuXxsRfaZpgHl6wb5eLPZi F3mImKMTSl9feXaYzFnVf5OtPOZYH/rLINu1QxvttL0HeVnQf0i6RQ1quXFRxjE+d4Ro WJiLyCIkCTAlsm2txRotBFwXqETsl2dMXNi7feFe+9yUh8s+rSkzkgf3MipiaigCNqiX l36L9zXjGuo6s4K6qt4CnOg+8VUh2DtwJFzLqNE6Y+wYr0VNPCcy6HkPSa4xpm90I2jy XiOsQnBlCwPwfm+DokOlqNKk2grgcCYlht/MJ4ZnEH7eGyurFObi54XdeZsmTiJ/1dSt M1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=v/v3EOCeKlH1yy1lBBdbnJgt8NXsE7ukja0JvSrCQjQ=; b=te1m9peKtY0/26cW7SgxKjVOyqJRoDJ5hOBgITuwmE1VIZZrMH83IseEHGQNYImigR 6NOWxaPPyZqORVnBKDLChW8qE7eeZotGWiyIAvJzmvNlYu6P4nnUt+Dd/uMNri2z4ykE fQpy4gtqj4R1znf5XiD4Sgo1cmxYm5JsfkUcRujFSRgBtI5upzyGODpgRyDcQ5AdWqmI xMhJ4YpSIclmvPxL1mNNmDXeYGFLUlE7Hdk0CmyLXngrRCtsCaLQ4qHNINROWWzwfKzC QiV8LrP5vXeHDzOW8cJ+0j6o8K5Bw0ZlHMl0tKvd4xdlTe94pVJU64e1g31GpAc1FZpt eeOg== X-Gm-Message-State: AGi0PuZ0RasTnWd/9scrQRkMY9FbLYVrrx64G7k//hfVTrSUFzOAqq0n uwBJb8IEtVbwDABXuSgZ4Ry+29dphVE3hF7SyfiPSg== X-Google-Smtp-Source: APiQypII/JsB+LYF2NyT6Q4N251TPQgr++zZZo+BiIULYVeFrP2T7zYy37qhEpV/Syk1GqNaKD4JaMLDMmplOFP/jq0= X-Received: by 2002:a05:6a00:42:: with SMTP id i2mr4102001pfk.108.1586289454742; Tue, 07 Apr 2020 12:57:34 -0700 (PDT) MIME-Version: 1.0 References: <29b5043db9a51ef7a0cb6e3a8c69c91e36045cd6.1585944770.git.mirq-linux@rere.qmqm.pl> <202004050928.d6QhVcsQ%lkp@intel.com> <20200407195546.GA744@qmqm.qmqm.pl> In-Reply-To: <20200407195546.GA744@qmqm.qmqm.pl> From: Nick Desaulniers Date: Tue, 7 Apr 2020 12:57:23 -0700 Message-ID: Subject: Re: [PATCH v3 07/11] power: supply: core: tabularize HWMON temperature labels To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: kbuild test robot , kbuild-all@lists.01.org, clang-built-linux , Andrey Smirnov , Guenter Roeck , Sebastian Reichel , LKML , linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 7, 2020 at 12:56 PM Micha=C5=82 Miros=C5=82aw wrote: > > On Tue, Apr 07, 2020 at 11:13:50AM -0700, Nick Desaulniers wrote: > > On Sat, Apr 4, 2020 at 6:53 PM kbuild test robot wrote: > > > > > > Hi "Micha=C5=82, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on power-supply/for-next] > > > [also build test WARNING on hwmon/hwmon-next linus/master v5.6 next-2= 0200404] > > > [if your patch is applied to the wrong git tree, please drop us a not= e to help > > > improve the system. BTW, we also suggest to use '--base' option to sp= ecify the > > > base tree in git format-patch, please see https://stackoverflow.com/a= /37406982] > > > > > > url: https://github.com/0day-ci/linux/commits/Micha-Miros-aw/exten= sions-and-fixes/20200405-044024 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-pow= er-supply.git for-next > > > config: x86_64-randconfig-b002-20200405 (attached as .config) > > > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project = 62f3a9650a9f289a07a5f480764fb655178c2334) > > > reproduce: > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # save the attached .config to linux build tree > > > COMPILER=3Dclang make.cross ARCH=3Dx86_64 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kbuild test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/power/supply/power_supply_hwmon.o: warning: objtool: power= _supply_hwmon_read_string() falls through to next function power_supply_hwm= on_write() > > > > I'm guessing this is from the unreachable: > > https://github.com/0day-ci/linux/commit/b8b2d14ca46ca54257f55c9af58ea25= 695b9ee36 > > I'll need to play with this some more as I couldn't reproduce with a > > simplified test case, but looks like a compiler bug. Filed > > https://github.com/ClangBuiltLinux/linux/issues/978 for me to track. > > Hi Nick, > > Just guessing: have you tried adding another unrelated function to the > testcase? I would expect that 'fall through to next function' needs > some other function to match. I was throwing the test case linked into godbolt and looking at the generated assembly. It contained no jumps, only movs and conditional movs. Thank you for the suggestion. --=20 Thanks, ~Nick Desaulniers