From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175B2C43217 for ; Mon, 9 May 2022 17:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239472AbiEIRNJ (ORCPT ); Mon, 9 May 2022 13:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239463AbiEIRNF (ORCPT ); Mon, 9 May 2022 13:13:05 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 207CB1E326B for ; Mon, 9 May 2022 10:09:11 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id t25so24921442lfg.7 for ; Mon, 09 May 2022 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=XlxYVyti/+Q7NqrSdb22SAIl6Y2j55Yg5g2k37ctvzV1ktFvUd3+GBrrXaqN+9NFeY 6EJHldsP4pwcrjQ2xzBRUlRSmr1Qray+IZ0Azb6pH9oGWAA6cH1MqKDYqSoobESAB3Tt eRGYGGgOM/icKjcAIArV0t0cRsOS98O3uc3oCmKTiATpvxAJt2dw7pFRGKnsUp5Fy6+q XIPCiWfYfE/TS6cBhvExSO/fG7/pxV+Gc6ing+pOzWL/ysqhEjHBgLIYNRnpXIBuNHwt 4ZGKV+R/g8mxG2EAM+mfZqER4WmDuwtD4WjdICN3razEbRrdkjkeh/S/AOCAatbdqrDm dp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=MsnT1mZedrAhzah2wAwxUZLQVrpmocr+rezzeCFHB2VsMeSwWnuTN2zHEUQZpWdoh0 3ZYvfMfaBr+yvyKClYJIcJEPYy+YQjY2527Lhqu3qPa3e4Wdn8FF0a4AJW92s67AfGix PjSizVMGwJvTfKsitXKlgpNLJUdSl6W0jADoJYffOGfZ2gSqHpI6XyAdkASXHz7WWQ6K KmI5ImrXa7Zm9rhfDqQJfgQkuUgUjulmTYCCUNprOrhGfRdYdkEPGT+dzBwzy6AL7JbU UEq2DIzG6XMboELTLTHt+hSTrZzJvMqmNvXkkaQ9JO5R/bZ5rmfwwcb3cS+fysXzUrE1 pryA== X-Gm-Message-State: AOAM533PJ8BUG0h3v3OpPMAHeKuc7/63Gt3YH+I79lyxczyF0NKTWCOF NZltT2BNJFr3C7uHvr96JGfv7yHrvbjTQluAB74PPQ== X-Google-Smtp-Source: ABdhPJwxw3I1e8oaAvfUjbq5Ev4Yd8NjV0buUyZoAzr7cbILcvl2TRmROPbsKEb/6HUIdbYLzAigXpP3dNIEtdsX6aE= X-Received: by 2002:a05:6512:1d1:b0:471:f63a:b182 with SMTP id f17-20020a05651201d100b00471f63ab182mr13052968lfp.392.1652116149145; Mon, 09 May 2022 10:09:09 -0700 (PDT) MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> <20220508190631.2386038-2-masahiroy@kernel.org> In-Reply-To: <20220508190631.2386038-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Mon, 9 May 2022 10:08:57 -0700 Message-ID: Subject: Re: [PATCH v4 01/14] modpost: remove left-over cross_compile declaration To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier , Peter Zijlstra , linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , Sami Tolvanen , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 8, 2022 at 12:09 PM Masahiro Yamada wrote: > > This is a remnant of commit 6543becf26ff ("mod/file2alias: make > modalias generation safe for cross compiling"). > > Signed-off-by: Masahiro Yamada Thanks for the patch! (I wonder if we should put our old mailing list in .mailmap?) Reviewed-by: Nick Desaulniers > --- > > Changes in v4: > - New patch > > scripts/mod/modpost.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h > index cfa127d2bb8f..d9daeff07b83 100644 > --- a/scripts/mod/modpost.h > +++ b/scripts/mod/modpost.h > @@ -174,7 +174,6 @@ static inline unsigned int get_secindex(const struct elf_info *info, > } > > /* file2alias.c */ > -extern unsigned int cross_build; > void handle_moddevtable(struct module *mod, struct elf_info *info, > Elf_Sym *sym, const char *symname); > void add_moddevtable(struct buffer *buf, struct module *mod); > -- -- Thanks, ~Nick Desaulniers