From: Nick Desaulniers <ndesaulniers@google.com>
To: Ian Rogers <irogers@google.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Stephane Eranian <eranian@google.com>,
Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v1 0/3] objtool build improvements
Date: Fri, 18 Nov 2022 09:46:57 -0800 [thread overview]
Message-ID: <CAKwvOdnc28gwv619=efnp2XYBFgv6fkSa8Z4t6M4XygPR+uC8A@mail.gmail.com> (raw)
In-Reply-To: <20221117220339.341290-1-irogers@google.com>
On Thu, Nov 17, 2022 at 2:03 PM Ian Rogers <irogers@google.com> wrote:
>
> Install libsubcmd and then get headers from there, this avoids
> inadvertent dependencies on things in tools/lib. Fix V=1
> support. Clean up how HOSTCC is used to override CC to avoid CFLAGS
> being set for say gcc, and then CC being overridden to clang. Support
> HOSTCFLAGS as a make option.
Hi Ian,
Thanks for the patch set! I'm particularly interested in fixing the
plumbing of HOSTCFLAGS into objtool properly.
Does this patch series depend on recent work you were doing to perf
and libsubcmd? When I apply it to mainline (84368d882b96) or
linux-next (20221118), I observe build failures with it.
```
/bin/sh: line 1: cd:
/android0/kernel-all/tools/objtool/libsubcmd/tools/objtool/: No such
file or directory
../../scripts/Makefile.include:17: *** output directory
"/android0/kernel-all/tools/objtool/libsubcmd/tools/objtool/" does not
exist. Stop.
make[3]: *** [Makefile:82:
/android0/kernel-all/tools/objtool/libsubcmd/libsubcmd.a] Error 2
make[3]: *** Waiting for unfinished jobs....
builtin-check.c:6:10: fatal error: 'subcmd/parse-options.h' file not found
#include <subcmd/parse-options.h>
^~~~~~~~~~~~~~~~~~~~~~~~
```
Which I also observe when just doing a regular kernel build and not
just tools/objtool/.
I tried to apply other recent series first, like
https://lore.kernel.org/lkml/20221109184914.1357295-1-irogers@google.com/
https://lore.kernel.org/linux-perf-users/20221116072211.2837834-2-irogers@google.com/
but wasn't quite able to get the result to build.
My plan to validate HOSTCFLAGS is:
$ make LLVM=1 -j128 mrproper defconfig tools/objtool HOSTCFLAGS=-Os
V=1 1> before.txt
$ <apply patch series>
$ make LLVM=1 -j128 mrproper defconfig tools/objtool HOSTCFLAGS=-Os
V=1 1> after.txt
$ meld before.txt after.txt
>
> Ian Rogers (3):
> objtool: Install libsubcmd in build
> objtool: Properly support make V=1
> objtool: Alter how HOSTCC is forced
>
> tools/objtool/Build | 2 --
> tools/objtool/Makefile | 68 +++++++++++++++++++++++++++++-------------
> 2 files changed, 48 insertions(+), 22 deletions(-)
>
> --
> 2.38.1.584.g0f3c55d4c2-goog
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2022-11-18 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 22:03 [PATCH v1 0/3] objtool build improvements Ian Rogers
2022-11-17 22:03 ` [PATCH v1 1/3] objtool: Install libsubcmd in build Ian Rogers
2022-11-17 22:03 ` [PATCH v1 2/3] objtool: Properly support make V=1 Ian Rogers
2022-11-17 22:03 ` [PATCH v1 3/3] objtool: Alter how HOSTCC is forced Ian Rogers
2022-11-18 17:46 ` Nick Desaulniers [this message]
2022-11-19 23:01 ` [PATCH v1 0/3] objtool build improvements Ian Rogers
2022-11-22 0:16 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnc28gwv619=efnp2XYBFgv6fkSa8Z4t6M4XygPR+uC8A@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).