From: Nick Desaulniers <ndesaulniers@google.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Peter Collingbourne <pcc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] x86: work around clang IAS bug referencing __force_order
Date: Fri, 14 Aug 2020 15:57:31 -0700 [thread overview]
Message-ID: <CAKwvOdnj6ObdpsdVYkDxWp-dVTTg=xMkBm84y419SNtLuAqfMg@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUWH5f4B_6eYy2_OOi45VjUkE_kN9akqvcOxxmmmM3TSrg@mail.gmail.com>
On Fri, Aug 14, 2020 at 2:19 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> On Fri, Aug 14, 2020 at 7:29 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > Thanks for the proposal.
> >
> > I have adapted it to fit my patchset against Linux v5.8.
> >
> > Both Debian's GCC-10 and a snapshot version of LLVM toolchain
> > v11.0.0-rc1+ seems to be OK.
> >
>
> Yupp, OK.
>
> I was able to boot FreeDOS 1.2 VM in VirtualBox GUI.
Hi Sedat,
Apologies, but it's not clear to me precisely which patch you tested.
Can you please confirm whether you tested:
1. Arnd's patch that started this thread.
2. My proposed diff adding -fno-addrsig to CFLAGS_powernow-k6.o.
3. My proposed diff removing __force_order from the kernel.
I'm hoping you were referring to testing 3., but it's not clear to me.
I've been comparing the full disassemblies of vmlinux images when
built with Clang with 3 applied (they're no different, which is a
pleasant surprise, I didn't think kernel builds woulds would be fully
deterministic given the sheer amount of source). I still need to
check the compressed vmlinux image, and various .ko's (XEN) that use
these read/write_cr[0,1,2,4]() functions, and then check them again
when built with GCC. I'm falling behind a little trying to get our MC
organized for plumbers, as well as the end of intern season and
beginning of bi-annual "performance review" ("not stack ranking" I'm
told) at work. If I don't find any differences, or if I do but don't
find them to be meaningful, I hope to push a more formal patch (rather
than just a diff) maybe next week. I'll include my findings either
way; if it was 3 that you tested, I'll include your tested by tag when
sending. Otherwise maybe you can help us test the more formal patch
next week?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-08-14 22:57 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:53 [PATCH] x86: work around clang IAS bug referencing __force_order Arnd Bergmann
2020-08-01 11:50 ` Sedat Dilek
2020-08-06 22:13 ` Thomas Gleixner
2020-08-07 7:03 ` Sedat Dilek
2020-08-04 0:09 ` Nick Desaulniers
2020-08-14 17:29 ` Sedat Dilek
2020-08-14 21:19 ` Sedat Dilek
2020-08-14 22:57 ` Nick Desaulniers [this message]
2020-08-15 0:26 ` Nick Desaulniers
2020-08-15 3:28 ` Sedat Dilek
2020-08-15 8:23 ` Sedat Dilek
2020-08-15 10:46 ` Sedat Dilek
2020-08-15 14:39 ` Sedat Dilek
2020-08-16 9:37 ` Sedat Dilek
2020-08-06 22:11 ` Thomas Gleixner
2020-08-13 0:12 ` Nick Desaulniers
2020-08-13 8:49 ` David Laight
2020-08-13 17:20 ` Arvind Sankar
2020-08-13 17:28 ` Thomas Gleixner
2020-08-13 17:37 ` Paul E. McKenney
2020-08-13 18:09 ` Arvind Sankar
2020-08-13 18:20 ` Paul E. McKenney
2020-08-20 10:44 ` Thomas Gleixner
2020-08-20 13:06 ` Arvind Sankar
2020-08-21 0:37 ` Thomas Gleixner
2020-08-21 23:04 ` Arvind Sankar
2020-08-21 23:16 ` Nick Desaulniers
2020-08-21 23:25 ` Arvind Sankar
2020-08-22 0:43 ` Thomas Gleixner
2020-08-22 3:55 ` Arvind Sankar
2020-08-22 8:41 ` Segher Boessenkool
2020-08-22 9:23 ` Sedat Dilek
2020-08-22 9:51 ` Sedat Dilek
2020-08-22 10:26 ` Segher Boessenkool
2020-08-22 10:35 ` Arnd Bergmann
2020-08-22 18:17 ` Miguel Ojeda
2020-08-22 21:08 ` Linus Torvalds
2020-08-22 23:10 ` Arvind Sankar
2020-08-23 0:10 ` Linus Torvalds
2020-08-23 1:16 ` Arvind Sankar
2020-08-23 21:25 ` [PATCH] x86/asm: Replace __force_order with memory clobber Arvind Sankar
2020-08-24 17:50 ` Nathan Chancellor
2020-08-24 19:13 ` Miguel Ojeda
2020-08-25 15:19 ` Arvind Sankar
2020-08-25 15:21 ` Sedat Dilek
2020-09-02 15:33 ` [PATCH v2] " Arvind Sankar
2020-09-02 15:58 ` David Laight
2020-09-02 16:14 ` Arvind Sankar
2020-09-02 16:08 ` Arvind Sankar
2020-09-02 20:26 ` David Laight
2020-09-02 17:16 ` Segher Boessenkool
2020-09-02 17:36 ` Arvind Sankar
2020-09-02 18:19 ` Miguel Ojeda
2020-09-02 18:24 ` Arvind Sankar
2020-09-02 23:21 ` [PATCH v3] " Arvind Sankar
2020-09-03 2:17 ` Kees Cook
2020-09-03 5:34 ` Miguel Ojeda
2020-09-30 20:50 ` Kees Cook
2020-10-01 10:12 ` [tip: x86/asm] x86/asm: Replace __force_order with a " tip-bot2 for Arvind Sankar
2020-10-13 9:30 ` tip-bot2 for Arvind Sankar
2020-08-22 21:17 ` [PATCH] x86: work around clang IAS bug referencing __force_order Arvind Sankar
2020-08-23 13:31 ` David Laight
2020-09-08 22:25 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnj6ObdpsdVYkDxWp-dVTTg=xMkBm84y419SNtLuAqfMg@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=andrew.cooper3@citrix.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pcc@google.com \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).