From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38573C388F9 for ; Sat, 7 Nov 2020 09:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B34208E4 for ; Sat, 7 Nov 2020 09:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uZ9BKTpi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbgKGJFB (ORCPT ); Sat, 7 Nov 2020 04:05:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728325AbgKGJE7 (ORCPT ); Sat, 7 Nov 2020 04:04:59 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C3B4C0613D2 for ; Sat, 7 Nov 2020 01:04:59 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id x15so1279044pll.2 for ; Sat, 07 Nov 2020 01:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YzyYN6jLumCnrlxnfcM2cNl/xFX6pvZ4pMXoDyQ+hD8=; b=uZ9BKTpiKDLn0lh+cWV+ISy4wKFzcOzsNcgzYdj5uoR7FvOqQ6WYqiQJHC7zU9klht RUnq/DaMt/ImWu8fdrje/NJ3+zsk+9YsqTIJaDcKC+/1RyQGCq/HrZXzBHK/0WWZdkXr VSLWWmcv9xkof/QBfhVm1E7fXXBPKmpprL99oDNVHmF4ZNLdIdon461Dee2Nzfmjr2Kr +73RPpeIy8HGqAVT0TExvj71YGfQST9ca2Ia5PdPjS9saCdRoulHwl0FLp/3JK5NHRRg hCp1OGm+r43LB2f3Hijz+1XVDyUi0B8VVAtwt8HvjmQIlEl3flH+/VZEV0zOjsmvCsQE yXLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YzyYN6jLumCnrlxnfcM2cNl/xFX6pvZ4pMXoDyQ+hD8=; b=dQSA7Tq9bQZa6lPuQ6+RhX8qqaR/nDKxIuD7UXofyS8IMSmLckxBBTQD07vJmoU74p 9PkeqbMWEgrgSaK7m4RHU8W7gfkBGN1JJQ828gwAPNfNfqrT9Y0le4pW7ZlN1IGkW7yi M8jI3KyzST5Z25P9/V0Y/SCPefKkNeAZR0NEBCc6GvBfSyIRTBaYWFPoz5yi09eAq4HL 1a4tqm13c5k/1bqgokiHK0ZRCfzdJMfhogavPS6gILmS/iF+7LiKro+HYAcfu883ofRy slvLshJ5HfAo9GYghq4L+kVuVIxKFzqEYnGh5QXxtUyn0SrR0s+KohJc4QmfWSxmR6ab Snig== X-Gm-Message-State: AOAM533hEfSMvF2qkUt3Uk2wXM3TXiHUWgbnEd/qi50UvZpKo9liMWT0 q7sPzK3vEE+TDwKbK6CxNEypCVKyxN1llr27tsy7aQ== X-Google-Smtp-Source: ABdhPJwALIFf+RxzOAhnKhr6v435co43bMJz7bfCpmyfdbAp1VM3/dmQ1QYT11ULq8o7hmLa5T4xzWZNcyXQNFJ9wfk= X-Received: by 2002:a17:902:760c:b029:d6:efa5:4cdd with SMTP id k12-20020a170902760cb02900d6efa54cddmr4919078pll.56.1604739898674; Sat, 07 Nov 2020 01:04:58 -0800 (PST) MIME-Version: 1.0 References: <20201107070744.1133811-1-ndesaulniers@google.com> <20201107084525.3417278-1-ndesaulniers@google.com> In-Reply-To: <20201107084525.3417278-1-ndesaulniers@google.com> From: Nick Desaulniers Date: Sat, 7 Nov 2020 01:04:47 -0800 Message-ID: Subject: Re: [PATCH v2] Revert "kbuild: Do not enable -Wimplicit-fallthrough for clang for now" To: Masahiro Yamada Cc: "Gustavo A . R . Silva" , Joe Perches , Michal Marek , Nathan Chancellor , Linux Kbuild mailing list , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 7, 2020 at 12:45 AM Nick Desaulniers wrote: > > This reverts commit e2079e93f562c7f7a030eb7642017ee5eabaaa10. > > This has been fixed up over time thanks to the addition of "fallthrough" > pseudo-keyword in > commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo > keyword for switch/case use") > > Link: https://github.com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers > --- > Changes V1 -> V2: > * We actually want a revert, not a partial revert. v1 removed > -Wimplicit-fallthrough outright, which we don't want. We still need > cc-option for GCC < 7. Gah, I tested a ton of configs with V1...but not V2...this patch is not ready yet. Sorry for the noise. -- Thanks, ~Nick Desaulniers