From: Nick Desaulniers <ndesaulniers@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Kees Cook <keescook@chromium.org>,
sparse@chrisli.org, linux-sparse@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
daniel.santos@pobox.com
Subject: Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()
Date: Fri, 31 Aug 2018 09:46:02 -0700 [thread overview]
Message-ID: <CAKwvOdnyA=Y_+KnJrDc5mu7twTAEOMXvb8cAZhwzsXTi7a9sEA@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdkD0cmF5373LRS92U--ptRvikSrG_oKyE-AiaybCQYMBg@mail.gmail.com>
On Tue, Aug 28, 2018 at 4:00 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Mon, Aug 27, 2018 at 1:42 PM Daniel Santos <daniel.santos@pobox.com> wrote:
> >
> > Hello Nick,
> >
> > On 08/27/2018 03:09 PM, Nick Desaulniers wrote:
> > >>> Let's give up __compiletime_assert_fallback(). This commit does not
> > >>> change the current behavior since it just rips off the useless code.
> > >> Clang is not the only target audience of
> > >> __compiletime_assert_fallback(). Instead of ripping out something that
> > >> may benefit builds with gcc 4.2 and earlier, why not override its
> > > Note that with commit cafa0010cd51 ("Raise the minimum required gcc
> > > version to 4.6") that gcc < 4.6 is irrelevant.
> >
> > Ah, I guess I'm not keeping up, that's wonderful news! Considering that
> > I guess I would be OK with its removal, but I still think it would be
> > better if a similar mechanism to break the Clang build could be found.
>
> I'm consulting with our best language lawyers to see what combinations
> of _Static_assert and __builtin_constant_p would do the trick.
Linus,
Can this patch be merged in the meantime?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-08-31 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 18:16 [PATCH v2] compiler.h: give up __compiletime_assert_fallback() Masahiro Yamada
2018-08-27 20:05 ` Daniel Santos
2018-08-27 20:09 ` Nick Desaulniers
2018-08-27 20:42 ` Daniel Santos
2018-08-27 21:01 ` Nick Desaulniers
2018-08-28 10:55 ` Arnd Bergmann
2018-08-28 13:46 ` Masahiro Yamada
2018-08-28 23:00 ` Nick Desaulniers
2018-08-31 16:46 ` Nick Desaulniers [this message]
2018-09-26 18:00 ` Matthias Kaehlcke
2018-09-26 18:03 ` Nick Desaulniers
2018-09-26 18:26 ` Kees Cook
2018-09-26 18:42 ` Greg KH
2018-09-26 18:45 ` Kees Cook
2018-09-26 19:03 ` Greg KH
2018-09-26 19:29 ` Nick Desaulniers
2018-09-26 19:35 ` Kees Cook
2018-10-10 6:10 ` Joel Stanley
2018-10-10 7:03 ` Miguel Ojeda
2018-10-10 14:49 ` Kees Cook
2018-10-11 2:48 ` Masahiro Yamada
2018-10-11 15:15 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnyA=Y_+KnJrDc5mu7twTAEOMXvb8cAZhwzsXTi7a9sEA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=daniel.santos@pobox.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).