From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Amit K Bag <amit.k.bag@intel.com>,
Chethan T N <chethan.tumkur.narayan@intel.com>,
Raghuram Hegde <raghuram.hegde@intel.com>,
linux-bluetooth@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to_bootloader
Date: Fri, 18 Oct 2019 15:39:08 -0700 [thread overview]
Message-ID: <CAKwvOdnycftgCanEt_BpUOB9Uo0sderk1HZp3H4EQ8drAmjohA@mail.gmail.com> (raw)
In-Reply-To: <20191018222924.49256-1-natechancellor@gmail.com>
On Fri, Oct 18, 2019 at 3:29 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> When building with Clang and CONFIG_BT_INTEL unset, the following error
> occurs:
>
> In file included from drivers/bluetooth/hci_ldisc.c:34:
> drivers/bluetooth/btintel.h:188:2: error: void function
> 'btintel_reset_to_bootloader' should not return a value [-Wreturn-type]
> return -EOPNOTSUPP;
> ^ ~~~~~~~~~~~
> 1 error generated.
>
> Remove the unneeded return statement to fix this.
>
> Fixes: b9a2562f4918 ("Bluetooth: btusb: Trigger Intel FW download error recovery")
> Link: https://github.com/ClangBuiltLinux/linux/issues/743
> Reported-by: <ci_notify@linaro.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/bluetooth/btintel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
> index d2311156f778..a69ea8a87b9b 100644
> --- a/drivers/bluetooth/btintel.h
> +++ b/drivers/bluetooth/btintel.h
> @@ -185,6 +185,5 @@ static inline int btintel_download_firmware(struct hci_dev *dev,
>
> static inline void btintel_reset_to_bootloader(struct hci_dev *hdev)
> {
> - return -EOPNOTSUPP;
The existing structure of this code is fishy, but I see what is going on with:
65 #if IS_ENABLED(CONFIG_BT_INTEL)
drivers/bluetooth/btintel.h
Thanks for the patch
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> }
> #endif
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-10-18 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:13 linux-next: build failure after merge of the bluetooth tree Stephen Rothwell
2019-10-18 22:29 ` [PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to_bootloader Nathan Chancellor
2019-10-18 22:39 ` Nick Desaulniers [this message]
2019-10-19 7:57 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdnycftgCanEt_BpUOB9Uo0sderk1HZp3H4EQ8drAmjohA@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=amit.k.bag@intel.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=natechancellor@gmail.com \
--cc=raghuram.hegde@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).