From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D078C4320A for ; Tue, 27 Jul 2021 22:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BED860F9C for ; Tue, 27 Jul 2021 22:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbhG0Wp3 (ORCPT ); Tue, 27 Jul 2021 18:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbhG0Wp0 (ORCPT ); Tue, 27 Jul 2021 18:45:26 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D14C061764 for ; Tue, 27 Jul 2021 15:45:26 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id i10so308643pla.3 for ; Tue, 27 Jul 2021 15:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c1rNywmSdGGjGqVOum2VanmkhITHWhYb0J24So7djoA=; b=TtkGy7LcJ0WaUCyu8a042D7dQ5rVq9C9zu07do3LnWSBuJ5oCbUqsDiU7RUSneJ/s6 ZH5v/8j9GH6ylGb4tQt/VqKvcFv/GAAG8YDIJWQqTBskmZukEkA+CGu8EFtyHO6bZJrg EPlodJpw0j7mGTlbwWK0YXKvfQaTUJulof0zg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c1rNywmSdGGjGqVOum2VanmkhITHWhYb0J24So7djoA=; b=F2Kl6Sw3ldKVlUehQa/ZtA+ZLdqUzNX6ddb8ZKzXgf6h92ecMKQ9dF5XHHvmAq8K2N Cg71nfsDXOBiXETkG6PiMfc5v6hxikfYZRXvXYE8pJu18zmnxj7zhSCEOXKkCCGvKZwn wS0Zx9a4U2aZiLPGfqkKdHZVTndxcavsQRL5mC6vCvi6w8bsK3WCx1sGz5n785SaM126 2vZggJJLQHk8qRHo0oV3waQYEgKVaXvaLGMMM5r5KKJ5tfBCBbtuJglTZbplnQkc9bLO S70e77AfbH94xLJ1UpLXRYSvCL1NGrro/LJqzhfYHPXmt8WKGSeStsJEqZmJQ2UfrPhR kMzw== X-Gm-Message-State: AOAM532y8GRLtpxCLWSMJfJpx+9ETjGBhF3/dBJMeW4XSntrvzUIo27N umgvJelJewG0HTdH+LmKRuJ58JNpSZSTgbEYj8vChg== X-Google-Smtp-Source: ABdhPJwuBW1u+RvaSDnnOQwgWCiGU3dOFFm7AXmwt8lUWMZ3xtjeLMUpHyNxEFomuxPLlrfXGToVv2Xas45ir3vVhhw= X-Received: by 2002:a17:902:e84d:b029:12b:b2aa:5266 with SMTP id t13-20020a170902e84db029012bb2aa5266mr20457222plg.65.1627425925801; Tue, 27 Jul 2021 15:45:25 -0700 (PDT) MIME-Version: 1.0 References: <20210727190001.914-1-kbowman@cloudflare.com> <20210727195459.GA15181@salvia> <20210727211029.GA17432@salvia> <20210727212730.GA20772@salvia> <20210727215240.GA25043@salvia> In-Reply-To: <20210727215240.GA25043@salvia> From: Alex Forster Date: Tue, 27 Jul 2021 17:45:09 -0500 Message-ID: Subject: Re: [PATCH] netfilter: xt_NFLOG: allow 128 character log prefixes To: Pablo Neira Ayuso Cc: Kyle Bowman , kernel-team , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Network Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, you can update iptables-nft to use nft_log instead of xt_LOG, > that requires no kernel upgrades and it will work with older kernels. I've always been under the impression that mixing xtables and nftables was impossible. Forgive me, but I just want to clarify one more time: you're saying we should be able to modify iptables-nft such that the following rule will use xt_bpf to match a packet and then nft_log to log it, rather than xt_log as it does today? iptables-nft -A test-chain -d 11.22.33.44/32 -m bpf --bytecode "1,6 0 0 65536" -j NFLOG --nflog-prefix "0123456789012345678901234567890123456789012345678901234567890123456789" We had some unexplained performance loss when we were evaluating switching to iptables-nft, but if this sort of mixing is possible then it is certainly worth reevaluating.