From: Evan Benn <evanbenn@chromium.org>
To: Julius Werner <jwerner@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Anson Huang <Anson.Huang@nxp.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Leonard Crestez <leonard.crestez@nxp.com>,
Li Yang <leoyang.li@nxp.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Will Deacon <will@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] watchdog: Add new arm_smc_wdt watchdog driver
Date: Tue, 28 Apr 2020 14:42:50 +1000 [thread overview]
Message-ID: <CAKz_xw0nQL2t1a-ofosLVb72JwSAGXCea5wOuddstOMrULNygg@mail.gmail.com> (raw)
In-Reply-To: <CAODwPW9-c8EcZh_zB6SwohzvHtCQasaNLQM0fj2bj5O5KuVPfg@mail.gmail.com>
On Fri, Apr 24, 2020 at 8:17 AM Julius Werner <jwerner@chromium.org> wrote:
>
> > + err = of_property_read_u32(pdev->dev.of_node, "arm,smc-id",
> > + &smc_func_id);
> > + if (err < 0)
> > + return err;
> > + watchdog_set_drvdata(wdd, (void *)(uintptr_t)smc_func_id);
>
> Your device tree binding says there's a default and this is optional.
> I think you need to change the code so that that's actually true.
I think I have misunderstood the device tree json-schema spec.
My intention was for the device tree to fill in a default value in the dtb for
arm,smc-id if it was omitted in the dts. But now I see that does not seem to
happen, I cannot really find any documentation of `default`, so I will just put
a documentation string in instead and force the default in the driver.
next prev parent reply other threads:[~2020-04-28 4:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 4:40 [PATCH v5 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-04-23 4:40 ` [PATCH v5 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog Evan Benn
2020-04-23 4:40 ` [PATCH v5 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-04-23 5:05 ` Guenter Roeck
2020-04-23 22:17 ` Julius Werner
2020-04-28 4:42 ` Evan Benn [this message]
2020-04-28 20:06 ` Julius Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKz_xw0nQL2t1a-ofosLVb72JwSAGXCea5wOuddstOMrULNygg@mail.gmail.com \
--to=evanbenn@chromium.org \
--cc=Anson.Huang@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=leonard.crestez@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcin.juszkiewicz@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).