From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751860AbbJXJL4 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 24 Oct 2015 05:11:56 -0400
Received: from mail-lf0-f66.google.com ([209.85.215.66]:35833 "EHLO
	mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750892AbbJXJLx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 24 Oct 2015 05:11:53 -0400
MIME-Version: 1.0
In-Reply-To: <1445614411-533-3-git-send-email-daniel.baluta@intel.com>
References: <1445614411-533-1-git-send-email-daniel.baluta@intel.com>
	<1445614411-533-3-git-send-email-daniel.baluta@intel.com>
Date: Sat, 24 Oct 2015 02:11:51 -0700
Message-ID: <CAKzfze_af0h-mucN41+A-Zra2iqrnq_yJK5L3kaPg0riQ=y-4g@mail.gmail.com>
Subject: Re: [PATCH v10 2/5] iio: core: Introduce IIO configfs support
From: Matt Ranostay <mranostay@gmail.com>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>, jlbec@evilplan.org,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        hch@lst.de, Hartmut Knaack <knaack.h@gmx.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        octavian.purdila@intel.com, pebolle@tiscali.nl,
        patrick.porlan@intel.com, adriana.reus@intel.com,
        constantin.musca@intel.com, marten@intuitiveaerial.com,
        cristina.opriceana@gmail.com, Peter Meerwald <pmeerw@pmeerw.net>,
        viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Tested-by: Matt Ranostay <matt.ranostay@intel.com>

On Fri, Oct 23, 2015 at 8:33 AM, Daniel Baluta <daniel.baluta@intel.com> wrote:
> This patch creates the IIO configfs root group. The group
> will appear under <mount-point>/iio/, usually /config/iio.
>
> We introduce configfs support in IIO in order to be able to easily
> create IIO objects from userspace. The first supported IIO objects
> are triggers introduced with next patches.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
>  drivers/iio/Kconfig                 |  8 ++++++
>  drivers/iio/Makefile                |  1 +
>  drivers/iio/industrialio-configfs.c | 50 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 59 insertions(+)
>  create mode 100644 drivers/iio/industrialio-configfs.c
>
> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> index 66792e7..d0f1ddb 100644
> --- a/drivers/iio/Kconfig
> +++ b/drivers/iio/Kconfig
> @@ -22,6 +22,14 @@ if IIO_BUFFER
>         source "drivers/iio/buffer/Kconfig"
>  endif # IIO_BUFFER
>
> +config IIO_CONFIGFS
> +       tristate "Enable IIO configuration via configfs"
> +       select CONFIGFS_FS
> +       help
> +         This allows configuring various IIO bits through configfs
> +         (e.g. software triggers). For more info see
> +         Documentation/iio/iio_configfs.txt.
> +
>  config IIO_TRIGGER
>         bool "Enable triggered sampling support"
>         help
> diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile
> index aeca726..4e8ac82 100644
> --- a/drivers/iio/Makefile
> +++ b/drivers/iio/Makefile
> @@ -7,6 +7,7 @@ industrialio-y := industrialio-core.o industrialio-event.o inkern.o
>  industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o
>  industrialio-$(CONFIG_IIO_TRIGGER) += industrialio-trigger.o
>
> +obj-$(CONFIG_IIO_CONFIGFS) += industrialio-configfs.o
>  obj-$(CONFIG_IIO_TRIGGERED_EVENT) += industrialio-triggered-event.o
>
>  obj-y += accel/
> diff --git a/drivers/iio/industrialio-configfs.c b/drivers/iio/industrialio-configfs.c
> new file mode 100644
> index 0000000..83563dd
> --- /dev/null
> +++ b/drivers/iio/industrialio-configfs.c
> @@ -0,0 +1,50 @@
> +/*
> + * Industrial I/O configfs bits
> + *
> + * Copyright (c) 2015 Intel Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published by
> + * the Free Software Foundation.
> + */
> +
> +#include <linux/configfs.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/kmod.h>
> +#include <linux/slab.h>
> +
> +#include <linux/iio/iio.h>
> +
> +static struct config_item_type iio_root_group_type = {
> +       .ct_owner       = THIS_MODULE,
> +};
> +
> +struct configfs_subsystem iio_configfs_subsys = {
> +       .su_group = {
> +               .cg_item = {
> +                       .ci_namebuf = "iio",
> +                       .ci_type = &iio_root_group_type,
> +               },
> +       },
> +       .su_mutex = __MUTEX_INITIALIZER(iio_configfs_subsys.su_mutex),
> +};
> +EXPORT_SYMBOL(iio_configfs_subsys);
> +
> +static int __init iio_configfs_init(void)
> +{
> +       config_group_init(&iio_configfs_subsys.su_group);
> +
> +       return configfs_register_subsystem(&iio_configfs_subsys);
> +}
> +module_init(iio_configfs_init);
> +
> +static void __exit iio_configfs_exit(void)
> +{
> +       configfs_unregister_subsystem(&iio_configfs_subsys);
> +}
> +module_exit(iio_configfs_exit);
> +
> +MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com>");
> +MODULE_DESCRIPTION("Industrial I/O configfs support");
> +MODULE_LICENSE("GPL v2");
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/