From: Jason Xing <kerneljasonxing@gmail.com>
To: stephen@networkplumber.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, kuniyu@amazon.com,
liuhangbin@gmail.com, xiangxia.m.yue@gmail.com, jiri@nvidia.com,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior
Date: Sun, 12 Mar 2023 08:04:23 +0800 [thread overview]
Message-ID: <CAL+tcoAUGyDS=khx7W8V79wck2HAFa2JFsY4-182ASy5m9w+Pw@mail.gmail.com> (raw)
In-Reply-To: <20230311091409.4f125e53@hermes.local>
On Sun, Mar 12, 2023 at 1:14 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Sun, 12 Mar 2023 00:36:14 +0800
> Jason Xing <kerneljasonxing@gmail.com> wrote:
>
> > - for (;;) {
> > + for (; is_continue;) {
>
>
> Easier to read this as a
> while (is_continue) {
>
> but what is wrong with using break; instead?
If we hit the budget limit and 'break;' immediately, we may miss the
collection when we also hit the time limit. That's why I would like to
know if we hit both of them.
Thank,
Jason
next prev parent reply other threads:[~2023-03-12 0:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 16:36 [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior Jason Xing
2023-03-11 17:14 ` Stephen Hemminger
2023-03-12 0:04 ` Jason Xing [this message]
2023-03-13 2:05 ` Jason Xing
2023-03-13 20:07 ` Simon Horman
2023-03-14 1:56 ` Jason Xing
2023-03-13 21:58 ` Kui-Feng Lee
2023-03-14 1:57 ` Jason Xing
2023-03-14 8:39 ` Jesper Dangaard Brouer
2023-03-14 9:21 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL+tcoAUGyDS=khx7W8V79wck2HAFa2JFsY4-182ASy5m9w+Pw@mail.gmail.com' \
--to=kerneljasonxing@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jiri@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).