From: "Fleming, Matt" <matt.fleming@intel.com>
To: Dave Young <dyoung@redhat.com>
Cc: "bp@alien8.de" <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
vgoyal@redhat.com
Subject: Re: [PATCH] export efi.flags to sysfs
Date: Tue, 27 May 2014 14:36:41 +0100 [thread overview]
Message-ID: <CAL01qpvqa-8u2MZ=8wE8gsiprFLbN4U3AbEX9+h7FuemXNR93Q@mail.gmail.com> (raw)
In-Reply-To: <20140527030058.GB2372@darkstar.nay.redhat.com>
On 27 May 2014 04:00, Dave Young <dyoung@redhat.com> wrote:
> On 05/26/14 at 04:39pm, Dave Young wrote:
>>
>> For efi=old_map and any old_map quirks like SGI UV in current
>> tree kexec/kdump will fail because it depends on the new 1:1 mapping.
>>
>> Thus export the mapping method to sysfs so kexec tools can switch
>> to original way to boot.
>>
>> Since we have efi.flags for all efi facilities so let's just export the
>> efi.flags itself, it maybe useful for other arches and use cases.
>
> Rethink about this issue, export flags will expose the efi facility
> macros to userspace, Matt, what's your opinion? It might be better to export
> a file 'old_map' only which is '0|1'
Exporting efi.flags is a non-starter. Those flags are part of an
internal interface and I'm not prepared to turn them into a userspace
ABI that we can never, ever change without a massive amount of pain.
I've only vaguely been following along with the other thread, so please
summarise everything again in your patch. Particularly, I need answers
to the following questions,
- Are you trying to fix a kexec/kdump regression?
- Does SGI UV work with kexec + UEFI at all?
The 1:1 mapping was required to make kexec + EFI work in the first
instance. If a machine implements the EFI 1:1 mapping, kexec should
work. If it doesn't implement the 1:1 mapping, then it's probably not
going to work, right?
The crux of the question: are you trying to fix a regression?
If not, then we just need to get SGI UV working with the EFI 1:1
mapping. No?
next prev parent reply other threads:[~2014-05-27 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 8:39 [PATCH] export efi.flags to sysfs Dave Young
2014-05-27 3:00 ` Dave Young
2014-05-27 13:36 ` Fleming, Matt [this message]
2014-05-28 2:09 ` Dave Young
2014-05-28 9:47 ` Dave Young
2014-05-28 15:51 ` Alex Thorlton
2014-05-28 19:04 ` Vivek Goyal
2014-05-28 20:11 ` Alex Thorlton
2014-05-29 11:58 ` Fleming, Matt
2014-05-29 2:37 ` Dave Young
2014-05-28 14:51 ` Vivek Goyal
2014-05-29 11:53 ` Fleming, Matt
2014-05-29 12:59 ` Vivek Goyal
2014-05-29 13:10 ` Fleming, Matt
2014-05-30 1:53 ` Dave Young
2014-05-27 13:34 ` Vivek Goyal
2014-05-28 2:13 ` Dave Young
2014-05-28 12:40 ` Vivek Goyal
2014-05-29 2:08 ` Dave Young
2014-05-29 9:09 ` Dave Young
2014-05-29 12:45 ` Vivek Goyal
2014-05-29 12:50 ` Borislav Petkov
2014-05-30 2:24 ` Dave Young
2014-05-30 7:33 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL01qpvqa-8u2MZ=8wE8gsiprFLbN4U3AbEX9+h7FuemXNR93Q@mail.gmail.com' \
--to=matt.fleming@intel.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).