From: Roland Dreier <roland@kernel.org>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] IB/mthca: remove deprecated use of pci api
Date: Tue, 17 Feb 2015 10:33:30 -0800 [thread overview]
Message-ID: <CAL1RGDU7cnR=uszxLiACEc8rLUty2T6Z6bZVx+_YjSzb9WpsZQ@mail.gmail.com> (raw)
In-Reply-To: <20150204140911.GA23076@sloth>
On Wed, Feb 4, 2015 at 6:09 AM, Quentin Lambert
<lambert.quentin@gmail.com> wrote:
> - dev->eq_table.icm_dma = pci_map_page(dev->pdev, dev->eq_table.icm_page, 0,
> - PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);
> - if (pci_dma_mapping_error(dev->pdev, dev->eq_table.icm_dma)) {
> + dev->eq_table.icm_dma = dma_map_page(&dev->pdev->dev,
> + dev->eq_table.icm_page, 0,
> + PAGE_SIZE,
> + (enum dma_data_direction)PCI_DMA_BIDIRECTIONAL);
Surely this can't be right? Shouldn't the direction just change to
DMA_BIDIRECTIONAL?
Are we really sweeping through the kernel and getting rid of pci_map_
etc. calls?
If so please respin your semantic patch so that it doesn't add crazy stuff like
(enum dma_data_direction)PCI_DMA_BIDIRECTIONAL
and resend the change.
Thanks,
Roland
prev parent reply other threads:[~2015-02-17 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 14:09 [PATCH 1/1] IB/mthca: remove deprecated use of pci api Quentin Lambert
2015-02-17 18:33 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1RGDU7cnR=uszxLiACEc8rLUty2T6Z6bZVx+_YjSzb9WpsZQ@mail.gmail.com' \
--to=roland@kernel.org \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).