From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22089C433F5 for ; Wed, 6 Oct 2021 00:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F41AA60F92 for ; Wed, 6 Oct 2021 00:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237019AbhJFA7g (ORCPT ); Tue, 5 Oct 2021 20:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231582AbhJFA7e (ORCPT ); Tue, 5 Oct 2021 20:59:34 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA34FC06174E for ; Tue, 5 Oct 2021 17:57:42 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r18so3162683edv.12 for ; Tue, 05 Oct 2021 17:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BnBbGM64QgB5WqzcyJW08etbln6pWC86wmdrU2FWwHk=; b=jq9S2dgjGpgRQfijmZdn0qh5bgVlzqhVZ9YJBI764wnh/E12jtFJ2PsOoeyo0oFIyR LHqk+MI1VVu0h7KDAtA59I+nITfVc00AJyvynBMYhqzLZPw8Z02I5zuWJYeR7q6wIY5m nVLO32I2DZyl62N73IIk6XUHS83X+YlV5v9UmFKEdkFPoLzMgIOeapoVNbikwiZvL9Nm 7bouOO6ZWYcMco3gu5muzmHlkOplwpYfX6brhibL4DWUBQhYp9W8xo2qbYmUPsHRheHI C3/TYxsC/tAiN6v2C3ZoIDig7SBYEXbUQCFf+qwQ+d43Au5j5mqebfmMslkcGzj+/lbU u8bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BnBbGM64QgB5WqzcyJW08etbln6pWC86wmdrU2FWwHk=; b=ess3vT182T44O9Uyc6gI01qWakHzeKAXU83ZOUnDZKUbrXU1l2g/rMBF234/YpUy+z UNevJ7abblknVVxlIU24SdpCWLy+guKpyWSyx9xVXsxgBxdUU1h+IDVGgH7Cq5W6caJu 4TaovSz8f4BSjz80DKyiZYHLsPOX6RSPhMiwcqT0qi512gIImNgh95BzhU/IaOcnWfzH z6doB0GTwQ9gIfs1uhYKKML6Z4vt8B1+W3xgNffOG78inNZYoAq7X+/rZTxNqEiIwSy1 Sq5CGeoGe9s6vPZXgWeAZgUHsEs5NM1IJzPXFeo+firGpJuAc7LKQET4s/FEOW9lnNa7 dqjQ== X-Gm-Message-State: AOAM530GupZbI1GUCOohCp12GLrJx7exCIDQq+sPOK6h1qA/eAgzlBGM 65RbvpNrAKki/KmE1KSDE8/uH7MW789UMBvuo2aHKA== X-Google-Smtp-Source: ABdhPJzAlobybkSmWpQ6ha24btcTyPI6Fe0fRQTXeGc7K0osnXOdlvUU2Svmk+mGvTY1LkqxvcAVltNOgEvreuqXjcw= X-Received: by 2002:a50:d8cf:: with SMTP id y15mr30842697edj.66.1633481861084; Tue, 05 Oct 2021 17:57:41 -0700 (PDT) MIME-Version: 1.0 References: <20210926033935.9258-1-irui.wang@mediatek.com> In-Reply-To: <20210926033935.9258-1-irui.wang@mediatek.com> From: Hirokazu Honda Date: Wed, 6 Oct 2021 09:57:30 +0900 Message-ID: Subject: Re: [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings To: Irui Wang Cc: Hans Verkuil , Tzung-Bi Shih , Alexandre Courbot , Tiffany Lin , Mauro Carvalho Chehab , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Fritz Koenig , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Irui, thank you for the patch. On Sun, Sep 26, 2021 at 12:39 PM Irui Wang wrote: > > Set recommend min/max bitrate range for MT8173 h264/vp8 encoder. > > Signed-off-by: Irui Wang I confirmed the patch worked with my own test. Tested-by: Hirokazu Honda -Hiro > > --- > This patch dependents on "Clean redundant encoder format definition", > which already accepted into linux-next.git: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/?id=4093eb21538ae4f2861b26f4615939e1fa50dc67 > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > index 4489a9744cd7..5dce3681ce94 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > @@ -388,8 +388,8 @@ static const struct mtk_vcodec_enc_pdata mt8173_avc_pdata = { > .num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264), > .output_formats = mtk_video_formats_output, > .num_output_formats = ARRAY_SIZE(mtk_video_formats_output), > - .min_bitrate = 1, > - .max_bitrate = 4000000, > + .min_bitrate = 64, > + .max_bitrate = 60000000, > .core_id = VENC_SYS, > }; > > @@ -400,7 +400,7 @@ static const struct mtk_vcodec_enc_pdata mt8173_vp8_pdata = { > .output_formats = mtk_video_formats_output, > .num_output_formats = ARRAY_SIZE(mtk_video_formats_output), > .min_bitrate = 64, > - .max_bitrate = 4000000, > + .max_bitrate = 9000000, > .core_id = VENC_LT_SYS, > }; > > -- > 2.25.1 >