From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9F3C433FE for ; Tue, 5 Oct 2021 17:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E29D611CC for ; Tue, 5 Oct 2021 17:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbhJERRJ (ORCPT ); Tue, 5 Oct 2021 13:17:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234459AbhJERRI (ORCPT ); Tue, 5 Oct 2021 13:17:08 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7DA2C06174E for ; Tue, 5 Oct 2021 10:15:17 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id v17so38652001wrv.9 for ; Tue, 05 Oct 2021 10:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aYgvStYcOejtbxI3GBqAVA0PqeF45Re1v5iKKxMB0b8=; b=oZomKywjpSlz/lBpue6LRwIeQfneUymX/ysx3izeUIXyExVOlsyuAyr2SGp7iY2tYH 694e1CsH6noXTZJAVm+bboYsJKntp/IRARCgrbeXw4ZC+FJJJd4pr36Xezb0ri8es3tm c2FjbR7pHiakCLZ0f6/dwuFXY79Mk6UcBQxEWGFp/1fxLQ7lletDjCb5LGPWZyMEMTfE FS8qkcW4DO+8p15QejwflEzzooEML9rnoDtj5tgHIHyPtJvAue3he6mp2LM94i1pFshp 9m0bCV09V3hzwtxgZx6MO/lPHo9EOGcxwCIiZFUytujB+dVdNPXUBaPn1dPDWu0Gcuej mB5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aYgvStYcOejtbxI3GBqAVA0PqeF45Re1v5iKKxMB0b8=; b=sEUsyGKX0Hp7WdRt044vInFshlD2T4/cqTD/MItMoDoHrJqM03CGotbBMQ5vfEMPi7 8F9GLMX1iogJvoPf1fsM32oDsqGINV5qgS/sidKrCSqtMv0M6OeB/adctiIrldOoWBIg dKCsGTkrnicYsk0Jm3yiG7dN3q1LsIHyEhPEsLQpvRrmchxwYUE6WK65Vgo4QuhIKrCX 2OYTS/1SFgNV1tm4hwPjVonfy2l1xzVGhXx0nyWz1ppz3i3xb7Nve9wtZF9EyL0lHLOT qZ6CXBHGvdMYM9NHVIKDkxzJJTEzFyvFCRgLg6yxmU0nm7PUtSjDx8KNolXg3MkD2Cc0 LfkA== X-Gm-Message-State: AOAM531EcAcPfXQVvAWyPzlYEVqjo6AOHxj2wGn8EfNr+3E4ahW3QOeU 45QJ1xWZw0xrESivmI4rJxwZZ9FhH8PqtlR8KqWqHA== X-Google-Smtp-Source: ABdhPJzCHlUM6CFs4wkG/LtO9IAanQ4F1107oJ25Yj7xAgfOPExUNELwXT9bvyaRFMIoDOmrUD7w5N20XZrGkUIKgc8= X-Received: by 2002:adf:ab57:: with SMTP id r23mr23864345wrc.199.1633454115815; Tue, 05 Oct 2021 10:15:15 -0700 (PDT) MIME-Version: 1.0 References: <20211005161833.1522737-1-lee.jones@linaro.org> In-Reply-To: From: Adam Langley Date: Tue, 5 Oct 2021 10:14:58 -0700 Message-ID: Subject: Re: [PATCH 1/1] sign-file: Use OpenSSL provided define to compile out deprecated APIs To: Eric Biggers Cc: Lee Jones , linux-kernel@vger.kernel.org, David Howells , David Woodhouse , keyrings@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 5, 2021 at 10:01 AM Eric Biggers wrote: > I ran into these same -Wdeprecated-declarations compiler warnings on another > project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. > The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't > actually ready yet, so we had to keep using the ENGINE API and just add > -Wno-deprecated-declarations to the compiler flags. > > Your patch just removes support for PKCS#11 in that case, which seems > undesirable. (Unless no one is actually using it?) The patch removes support when OPENSSL_NO_ENGINE is defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.) When OPENSSL_NO_ENGINE is defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions: https://github.com/openssl/openssl/blob/master/include/openssl/engine.h . Cheers AGL