From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC25C433DB for ; Mon, 29 Mar 2021 08:14:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01DA8619C2 for ; Mon, 29 Mar 2021 08:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232790AbhC2IOA (ORCPT ); Mon, 29 Mar 2021 04:14:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231771AbhC2IIf (ORCPT ); Mon, 29 Mar 2021 04:08:35 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B94DEC061574; Mon, 29 Mar 2021 01:08:32 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id z136so11832730iof.10; Mon, 29 Mar 2021 01:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M90PtnBos3vQm4jCYdp24IMqWu4umlMBuWXWPsG5RUI=; b=XDcojEEvHw7VjId4QVIJ4x75QaQSNdQdx6b5ynGSdQ6rRtpfhVw3hYWVopCzz+i8Mx MawpBVFqghbwm+t0GQto3ccA5RVfnkV3zhieuKICgbyD6UJ6Sx3tu1S4gvu25AIypxJU IrKNadU9KlRCsAwt6Ko0ND6l2IDtAgziZ+pH8H/M12uTdgWUctXPf+is6ylHU5dG30LP 23chMnymCz9holZnfdWVaE0K1NcDfitMSls/YRpfvS79iNgkcKeX0S4J4W7gluJR/eI9 xKaXdVxCUx/E4UzDo7vvmkOvsu8ruOXJPNRblW96dd+8K8IFzs2tlrn/HjgncWfQh7J2 gUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M90PtnBos3vQm4jCYdp24IMqWu4umlMBuWXWPsG5RUI=; b=m1HDQStjxW7EQeFiRMNnhtjdwUL44dPOybJN41wqkxGuaNstQpbJCsU1lu0UBvFogY S+V08stBE1UvMNLr8H4Kli4TAaYb5ogCTBM0IK3RZn/vHb2JyaSC7d6WQCg1A3impYW+ n81vJWSWS4cYT5g7CFj8J0cGZ5NiFsBsAXepJaHf/iLQKt3p0KPgTWXCJQi+HxFJjTw8 cs1eA2R0h159FoM8ZNb6hcxCWipPnhicVQKhLGg+LQY3W0KPch/s4UctPmTdxqg3aI+k AVh4ToXmOIE7EmPU7MVSRSXiwjeM/sxGh+UIZlxRI3PZ9P34bvsKC8eTzmtD0U3k/uTp 582Q== X-Gm-Message-State: AOAM531CK2DdF0+iAY//xvOvgNOaAcQ4ddFXDsJ9ANd3Sgmc5VBGNOVC 9gwuUnsT/cvzj4UNxKsuW+ySc4ZcH5VkYn4oBnM= X-Google-Smtp-Source: ABdhPJwf+nNTr4QHEViurBtr2d3/xvlbhnLb599B6ZVv54r8NPMEKvz7hwFVeFk/Dn/uBm2Zk+aTqvnqBv1DHzEi4u8= X-Received: by 2002:a05:6602:280f:: with SMTP id d15mr18461754ioe.127.1617005312167; Mon, 29 Mar 2021 01:08:32 -0700 (PDT) MIME-Version: 1.0 References: <1615530274-31422-1-git-send-email-dillon.minfei@gmail.com> <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Mon, 29 Mar 2021 16:07:56 +0800 Message-ID: Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support To: Alexandre TORGUE Cc: Rob Herring , Ahmad Fatoum , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , Linux Kernel Mailing List , linux@armlinux.org.uk, Vladimir Murzin , afzal.mohd.ma@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 29, 2021 at 4:00 PM Alexandre TORGUE wrote: > > Hi Dillon > > On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote: > > From: dillon min > > > > This patch adds STM32H750 pinctrl and GPIO support > > since stm32h750 has the same pin alternate functions > > with stm32h743, so just reuse the stm32h743's pinctrl > > driver > > > > Signed-off-by: dillon min > > --- > > v2: > > - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they > > have same pin alternate functions > > - add STM32H750 to Kconfig description > > > > drivers/pinctrl/stm32/Kconfig | 2 +- > > drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig > > index f36f29113370..fb1ffc94c57f 100644 > > --- a/drivers/pinctrl/stm32/Kconfig > > +++ b/drivers/pinctrl/stm32/Kconfig > > @@ -35,7 +35,7 @@ config PINCTRL_STM32F769 > > select PINCTRL_STM32 > > > > config PINCTRL_STM32H743 > > - bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 > > + bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743 > > depends on OF && HAS_IOMEM > > default MACH_STM32H743 > > select PINCTRL_STM32 > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > > index ffe7b5271506..700206c7bc11 100644 > > --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c > > +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > > @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = { > > .compatible = "st,stm32h743-pinctrl", > > .data = &stm32h743_match_data, > > }, > > + { .compatible = "st,stm32h750-pinctrl", > > + .data = &stm32h743_match_data, > > + }, > > If you use exactly the same driver (i.e. same ball out and AF mux) then > you don't have to create a new compatible for that. Just use the same > than h743.(so you don't have to factorize DT files). Okay, yes they are the total same ball out and AF mux. I will delete it in the next submission. Just a kindly reminder , the newest version of this patchset is [PATCH v6]. Thanks. > > Regards > Alex > > > { } > > }; > > > >