From: John Stultz <john.stultz@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Anders Roxell <anders.roxell@linaro.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators
Date: Mon, 1 Oct 2018 14:56:10 -0700 [thread overview]
Message-ID: <CALAqxLU-fWHQetRFeghbe+XT504YXHFXLVi6CbBsXisNSdQ-OA@mail.gmail.com> (raw)
In-Reply-To: <20181001204346.4655-1-linus.walleij@linaro.org>
On Mon, Oct 1, 2018 at 1:43 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> commit efdfeb079cc3
> ("regulator: fixed: Convert to use GPIO descriptor only")
> switched to use gpiod_get() to look up the regulator from the
> gpiolib core whether that is device tree or boardfile.
>
> This meant that we activate the code in
> a603a2b8d86e ("gpio: of: Add special quirk to parse regulator flags")
> which means the descriptors coming from the device tree already
> have the right inversion and open drain semantics set up from
> the gpiolib core.
>
> As the fixed regulator was inspected again we got the
> inverted inversion and things broke.
>
> Fix it by ignoring the config in the device tree for now: the
> later patches in the series will push all inversion handling
> over to the gpiolib core and set it up properly in the
> boardfiles for legacy devices, but I did not finish that
> for this kernel cycle.
>
> Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only")
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Reported-by: John Stultz <john.stultz@linaro.org>
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This seems to solve it!
Tested-by: John Stultz <john.stultz@linaro.org>
next prev parent reply other threads:[~2018-10-01 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 20:43 [PATCH] regulator: fixed: Default enable high on DT regulators Linus Walleij
2018-10-01 21:56 ` John Stultz [this message]
2018-10-02 13:42 ` Leonard Crestez
2018-10-03 12:10 ` Mark Brown
2018-10-03 18:08 ` Leonard Crestez
2018-10-04 7:19 ` Linus Walleij
2018-10-04 10:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLU-fWHQetRFeghbe+XT504YXHFXLVi6CbBsXisNSdQ-OA@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=anders.roxell@linaro.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).