linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Jens Axboe <axboe@kernel.dk>, David Anderson <dvander@google.com>,
	Alistair Delva <adelva@google.com>, Todd Kjos <tkjos@google.com>,
	Amit Pundir <amit.pundir@linaro.org>,
	YongQin Liu <yongqin.liu@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-block@vger.kernel.org, Satya Tangirala <satyat@google.com>
Subject: Re: [REGRESSION] "split bio_kmalloc from bio_alloc_bioset" causing crash shortly after bootup
Date: Tue, 23 Feb 2021 14:46:13 -0800	[thread overview]
Message-ID: <CALAqxLU5AU2jhEe=pa0=ye=8uYQeAw-4T86c36qCTipe9JE3OA@mail.gmail.com> (raw)
In-Reply-To: <20210223072252.GA18035@lst.de>

On Mon, Feb 22, 2021 at 11:22 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Feb 23, 2021 at 08:04:08AM +0100, Christoph Hellwig wrote:
> > The problem is that the blk-crypto fallback code calls bio_split
> > with a NULL bioset.  That was aready broken before, as the mempool
> > needed to guarantee forward progress was missing, but is not fatal.
> >
> > Satya, can you look into adding a mempool that can guarantees forward
> > progress here?
>
> Something like this would be the minimum viable fix:

This seems to work for me!

Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

      reply	other threads:[~2021-02-23 23:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23  3:06 [REGRESSION] "split bio_kmalloc from bio_alloc_bioset" causing crash shortly after bootup John Stultz
2021-02-23  3:39 ` Chaitanya Kulkarni
2021-02-23  4:22   ` John Stultz
2021-02-23  4:58     ` Chaitanya Kulkarni
2021-02-23  7:11     ` Christoph Hellwig
2021-02-23  3:51 ` Chaitanya Kulkarni
2021-02-23  7:10   ` Christoph Hellwig
2021-02-23  7:21     ` Chaitanya Kulkarni
2021-02-23  7:37     ` Chaitanya Kulkarni
2021-02-23 15:08       ` Christoph Hellwig
2021-02-23 15:12         ` Christoph Hellwig
2021-02-23 20:53         ` Chaitanya Kulkarni
2021-02-23  7:04 ` Christoph Hellwig
2021-02-23  7:22   ` Christoph Hellwig
2021-02-23 22:46     ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLU5AU2jhEe=pa0=ye=8uYQeAw-4T86c36qCTipe9JE3OA@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=adelva@google.com \
    --cc=amit.pundir@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dvander@google.com \
    --cc=hch@lst.de \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyat@google.com \
    --cc=tkjos@google.com \
    --cc=yongqin.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).