From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbbDBSCO (ORCPT ); Thu, 2 Apr 2015 14:02:14 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:33554 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbbDBSCL (ORCPT ); Thu, 2 Apr 2015 14:02:11 -0400 MIME-Version: 1.0 In-Reply-To: <551D177E.80203@redhat.com> References: <1427327073-19011-1-git-send-email-john.stultz@linaro.org> <5513EE03.1020507@redhat.com> <551D177E.80203@redhat.com> Date: Thu, 2 Apr 2015 11:02:11 -0700 Message-ID: Subject: Re: [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM From: John Stultz To: Prarit Bhargava Cc: Tyler Baker , lkml , Shuah Khan , Thomas Gleixner , Richard Cochran Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 2, 2015 at 3:18 AM, Prarit Bhargava wrote: > On 03/26/2015 01:33 PM, Tyler Baker wrote: >> I realize this may be a good amount of work, so I'd like to help out. >> Perhaps working John to convert his timer tests to use TAP output >> would be a good starting point? > > John, I could probably do that for you. I'm always willing to give it a shot. I took a quick look into it, since I'm definitely interested in improving output formatting, but man, TAP is a fairly ugly output format if you ask me. It only has binary "ok" or "not ok" (why not "fail", or something else that's exclusively grep-able, I don't know). So I'm not sure if cases where functionality is unsupported should be a pass or fail. Most problematically: It seems to want enumeration in the test output (so test 2 needs to print: "ok 2 Test complete") which means either there needs to be a wrapper that does the TAP output knowing which test of N its currently running, or the test number needs to be submitted as an runtime argument to the test, and the test then has to add it to its output line. Anyway, if we do want to go with that format, I suspect it should be something we add to the kselftest pass/fail hooks, rather then to the individual tests. Then its just a matter of prefixing normal test output with #'s so they can be ignored by the parser. thanks -john