From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88422CA9EAE for ; Tue, 29 Oct 2019 18:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E5F520679 for ; Tue, 29 Oct 2019 18:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lKvQS0hH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731417AbfJ2S0P (ORCPT ); Tue, 29 Oct 2019 14:26:15 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39444 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731329AbfJ2S0O (ORCPT ); Tue, 29 Oct 2019 14:26:14 -0400 Received: by mail-ot1-f66.google.com with SMTP id t8so4522512otl.6 for ; Tue, 29 Oct 2019 11:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F0/jbrX4IDouWf5n0Ojei70Kw+dN6xE0YN1q94WIUzA=; b=lKvQS0hHD4pj59HlV6oR0/djUnPuGpWekyavljQi7ntMzsbNBbY5kRUKP+N9n4IUtd maRk/snxO5ptQrmheK+AFhcB0qusQUQU9uqxU+S4Dp7WHJe3cw9tF8YosUx3hoRuYI9r nVedD3689ILaB3NAEDt95fwjMDA4JMq+1bEgKiaTqmc7r9enukmH6wTRiyL/ijQEmkDp 0sJWD7FDkSoJ6OaZxsmOw678g00dsavQbZN+uy+jhW6kx0F+GAXZRW8+pIWB/7adGLKJ 5GSo+Xo7uAoDCvHllODyrCQKxRPr0HLhXP4igjRfuz9Xb5Z+Q3BpsxOxg+izWGYDwufy SoAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F0/jbrX4IDouWf5n0Ojei70Kw+dN6xE0YN1q94WIUzA=; b=twlvrEqS4yKWBICOR4XibBUTPejmnsJihOaVT92Az2cnnytPBjpUXVOLYWQJOEPeGm hWEmqCamUsX/iGYqL1G/5vFkMSvQ6X6gs/Uk6ipp5A0OH7rrsoOXDkp5SdoYN1xZeZ6C N578Hj2BCxdSqjlZshO8vSFPwXcjgm52JmDW+nWvYeCBr87JbRqXb50nSqDh0I3U5qg6 sdKAygC8137fMtkMr0r5YZMDdN9sbiEEh1pnl9HyeQeLEB++2/iHhnYdko8uq1i6bDGr sCY1lQIBpDij2kFPivGSBoy2/ANDL6eYWO3lOHSB5xjjYZGvgdPgX38FmMbAEgH41LW6 5X+w== X-Gm-Message-State: APjAAAXOa9xUbp2Sv2BI1Xit9Ug09HoQhCL90uKpqR9xIRf+BBPHTa2i BAkwGm1fEQYhqFJC9kEHURSoc1ko/3ptSi5NMgVYDw== X-Google-Smtp-Source: APXvYqxMuKgV9hIGV28BZLBjcSzYuevoUIQsOkCa/3osxr8otj1CMRnSYhoMgINxrs/ynaGGsktybzxiSTkQJHs2gQk= X-Received: by 2002:a05:6830:ca:: with SMTP id x10mr18348228oto.221.1572373573201; Tue, 29 Oct 2019 11:26:13 -0700 (PDT) MIME-Version: 1.0 References: <20191028215919.83697-1-john.stultz@linaro.org> <20191028215919.83697-9-john.stultz@linaro.org> <87bltzj47a.fsf@gmail.com> In-Reply-To: <87bltzj47a.fsf@gmail.com> From: John Stultz Date: Tue, 29 Oct 2019 11:26:01 -0700 Message-ID: Subject: Re: [PATCH v4 8/9] dt-bindings: usb: generic: Add role-switch-default-host binding To: Felipe Balbi Cc: lkml , Greg Kroah-Hartman , Rob Herring , Mark Rutland , ShuFan Lee , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Yu Chen , Hans de Goede , Andy Shevchenko , Jun Li , Valentin Schneider , Jack Pham , Linux USB List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 2:23 AM Felipe Balbi wrote: > John Stultz writes: > > > Add binding to configure the default role the controller > > assumes is host mode when the usb role is USB_ROLE_NONE. > > ... > > + - role-switch-default-host: boolean, indicating if usb-role-switch is enabled > > + the device default operation mode of controller while > > + usb role is USB_ROLE_NONE is host mode. If this is not > > + set or false, it will be assumed the default is device > > + mode. > > Do we also need a role-switch-default-peripheral? Would it be better to > have a single role-switch-default property which accepts "host" or > "peripheral" arguments? I guess the standard default is peripheral, so this differentiated from that, but I agree it might be more forward thinking to let it specify a type argument in case there is another option in the future. I'll rework this. Thanks again for the review and feedback! -john