From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbcBHSu7 (ORCPT ); Mon, 8 Feb 2016 13:50:59 -0500 Received: from mail-yw0-f169.google.com ([209.85.161.169]:33258 "EHLO mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbcBHSu6 (ORCPT ); Mon, 8 Feb 2016 13:50:58 -0500 MIME-Version: 1.0 In-Reply-To: <20160207224919.GA29549@kroah.com> References: <1454134058-16466-1-git-send-email-john.stultz@linaro.org> <1454134058-16466-4-git-send-email-john.stultz@linaro.org> <20160207224919.GA29549@kroah.com> Date: Mon, 8 Feb 2016 10:50:57 -0800 Message-ID: Subject: Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak From: John Stultz To: Greg KH Cc: lkml , San Mehat , Android Kernel Team Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 7, 2016 at 2:49 PM, Greg KH wrote: > On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote: >> From: San Mehat >> >> As it turns out, the CONFIG_PROFILING interfaces leak a >> task struct if the notifier chain returns NOTIFY_OK.. doh. >> >> This patch reworks lowmemkiller to use the new generic task >> free notifier chain. >> >> Cc: Android Kernel Team >> Cc: Greg KH >> Signed-off-by: San Mehat >> [jstultz: Commit subject tweak] >> Signed-off-by: John Stultz >> --- >> drivers/staging/android/lowmemorykiller.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c >> index 8b5a4a8..806643d 100644 >> --- a/drivers/staging/android/lowmemorykiller.c >> +++ b/drivers/staging/android/lowmemorykiller.c >> @@ -40,7 +40,6 @@ >> #include >> #include >> #include >> -#include >> #include >> >> static u32 lowmem_debug_level = 1; >> -- >> 1.9.1 > > The changelog comment seems a bit "odd" when looking at the patch here. > Is the patch really correct? The changelog? Yea. Sorry for my oversight here. Had to do some patch archaeology and found that the content of that patch basically dropped out when 83dbbdbb38 ("android, lowmemorykiller: remove task handoff notifier") landed upstream in 3.4. Since then its been rebased along being basically content-less. So please ignore it. I'll try to get it dropped from the AOSP tree. thanks -john