From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751198AbcFWUbb (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jun 2016 16:31:31 -0400
Received: from mail-oi0-f52.google.com ([209.85.218.52]:33294 "EHLO
	mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750785AbcFWUba (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jun 2016 16:31:30 -0400
MIME-Version: 1.0
In-Reply-To: <20160623004716.GA26808@dtor-ws>
References: <1465944212-17079-1-git-send-email-john.stultz@linaro.org>
 <1465944212-17079-2-git-send-email-john.stultz@linaro.org>
 <CALAqxLWeG5Lj8Gg7kSeh6x-xM-tVNRQcttPdpk_Y07+65UJMbw@mail.gmail.com> <20160623004716.GA26808@dtor-ws>
From: John Stultz <john.stultz@linaro.org>
Date: Thu, 23 Jun 2016 13:31:28 -0700
Message-ID: <CALAqxLVHgoXcUGj==FqJP6mU8JdoM5XNr1aUpEDJ6xDHF=2htg@mail.gmail.com>
Subject: Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>, Feng Chen <puck.chen@hisilicon.com>,
        Wei Xu <xuwei5@hisilicon.com>, Guodong Xu <guodong.xu@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 22, 2016 at 5:47 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Jun 21, 2016 at 05:06:23PM -0700, John Stultz wrote:
>> On Tue, Jun 14, 2016 at 3:43 PM, John Stultz <john.stultz@linaro.org> wrote:
>> > From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> >
>> > This driver provides a input driver for the power button on the
>> > HiSi 65xx SoC for boards like HiKey.
>> >
>> > This driver was originally by Zhiliang Xue <xuezhiliang@huawei.com>
>> > then basically rewritten by Jorge, but preserving the original
>> > module author credits.
>> >
>> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> > Cc: Rob Herring <robh+dt@kernel.org>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> > Cc: Feng Chen <puck.chen@hisilicon.com>
>> > Cc: Wei Xu <xuwei5@hisilicon.com>
>> > Cc: Guodong Xu <guodong.xu@linaro.org>
>> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> > [jstultz: Reworked commit message, folded in other fixes/cleanups
>> > from Jorge, implemented some larger cleanups suggested by DmitryT]
>> > Signed-off-by: John Stultz <john.stultz@linaro.org>
>> > ---
>> > v2: Major rework integrating feedback from Dmitry.
>> > v3: Dropped of_match compatible line since no longer using DT
>> >     for this.
>> > v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line
>> >     I missed in the last revision, which casued build issues w/
>> >     modules.
>>
>> Hey Dmitry,
>>   Just wanted to ping you to see if there was anything else you were
>> wanting changed with this patch. Lee has queued the mfd patches in
>> -next, so I wanted to be sure to address any concerns you had that was
>> keeping this from heading upstream in 4.8 (hopefully :).
>
> Right, sorry, does the following look OK to you?
>

Yes! It looks great (and I tested it works too)!

Do you want to fold that in, or do you need me to re-submit with those changes?

thanks
-john