From: John Stultz <john.stultz@linaro.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Rob Clark <robdclark@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
lkml <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Xinliang Liu <z.liuxinliang@hisilicon.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Rongrong Zou <zourongrong@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Matt Redfearn <matt.redfearn@thinci.com>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic
Date: Wed, 11 Sep 2019 19:38:50 -0700 [thread overview]
Message-ID: <CALAqxLVP=x9+p9scGyfgFUMN2di+ngOz9-fWW=A1YCM4aN7JRA@mail.gmail.com> (raw)
In-Reply-To: <9d31af23-8a65-d8e8-b73d-b2eb815fcd6f@samsung.com>
On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda <a.hajda@samsung.com> wrote:
> On 03.09.2019 18:18, John Stultz wrote:
> > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >> On 30.08.2019 19:00, Rob Clark wrote:
> >>> On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >>>> Of course it seems you have different opinion what is the right thing in
> >>>> this case, so if you convince us that your approach is better one can
> >>>> revert the patch.
> >>> I guess my strongest / most immediate opinion is to not break other
> >>> existing adv75xx bridge users.
> >>
> >> It is pity that breakage happened, and next time we should be more
> >> strict about testing other platforms, before patch acceptance.
> >>
> >> But reverting it now will break also platform which depend on it.
> > I'm really of no opinion of which approach is better here, but I will
> > say that when a patch breaks previously working boards, that's a
> > regression and justifying that some other board is now enabled that
> > would be broken by the revert (of a patch that is not yet upstream)
> > isn't really a strong argument.
> >
> > I'm happy to work with folks to try to fixup the kirin driver if this
> > patch really is the right approach, but we need someone to do the same
> > for the db410c, and I don't think its fair to just dump that work onto
> > folks under the threat of the board breaking.
>
>
> These drivers should be fixed anyway - assumption that
> drm_bridge/drm_panel will be registered before the bus it is attached to
> is just incorrect.
>
> So instead of reverting, fixing and then re-applying the patch I have
> gently proposed shorter path. If you prefer long path we can try to go
> this way.
>
> Matt, is the pure revert OK for you or is it possible to prepare some
> workaround allowing cooperation with both approaches?
Rob/Andrzej: What's the call here?
Should I resubmit the kirin fix for the adv7511 regression here?
Or do we revert the adv7511 patch? I believe db410c still needs a fix.
I'd just like to keep the HiKey board from breaking, so let me know so
I can get the fix submitted if needed.
thanks
-john
next prev parent reply other threads:[~2019-09-12 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190829060605epcas3p4e67faa772911b8b84fee026fe953ca15@epcas3p4.samsung.com>
2019-08-29 6:05 ` [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic John Stultz
2019-08-29 14:57 ` Andrzej Hajda
2019-08-29 17:39 ` Rob Clark
2019-08-30 6:51 ` Andrzej Hajda
2019-08-30 17:00 ` Rob Clark
2019-09-02 13:22 ` Andrzej Hajda
2019-09-03 16:00 ` Rob Clark
2019-09-03 16:18 ` John Stultz
2019-09-04 10:26 ` Andrzej Hajda
2019-09-12 2:38 ` John Stultz [this message]
2019-09-12 13:21 ` Andrzej Hajda
2019-09-12 14:18 ` Matt Redfearn
2019-09-13 8:47 ` Andrzej Hajda
2019-09-13 21:15 ` John Stultz
2019-09-14 15:43 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLVP=x9+p9scGyfgFUMN2di+ngOz9-fWW=A1YCM4aN7JRA@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=amit.pundir@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.redfearn@thinci.com \
--cc=narmstrong@baylibre.com \
--cc=robdclark@gmail.com \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).