linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Prarit Bhargava <prarit@redhat.com>,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] time: alarmtimer: Add tracepoints for alarmtimers
Date: Tue, 6 Sep 2016 17:10:44 -0700	[thread overview]
Message-ID: <CALAqxLVW8+kVCrB-deEt6mixQLWpwC9TQ0Uw84ew4gJuoDVQ+A@mail.gmail.com> (raw)
In-Reply-To: <20160906094942.GA29689@gmail.com>

On Tue, Sep 6, 2016 at 2:49 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * tip-bot for Baolin Wang <tipbot@zytor.com> wrote:
>
>> Commit-ID:  a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021
>> Gitweb:     http://git.kernel.org/tip/a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021
>> Author:     Baolin Wang <baolin.wang@linaro.org>
>> AuthorDate: Mon, 22 Aug 2016 12:23:14 +0800
>> Committer:  John Stultz <john.stultz@linaro.org>
>> CommitDate: Wed, 31 Aug 2016 14:44:18 -0700
>>
>> time: alarmtimer: Add tracepoints for alarmtimers
>
> FYI, this commit causes a build failure on the S390 defconfig:
>
>   kernel/built-in.o:/home/mingo/tip/include/trace/events/alarmtimer.h:62: more undefined references to `rtc_ktime_to_tm' follow
>
> Removing that commit solved the build failure. Other architectures (that I
> checked) build fine.

Baolin: It looks like the issue is rtc_ktime_to_tm is defined in the
CONFIG_RTC_LIB optional drivers/rtc/rtc-lib.c, which s390 does not
include.

Something like (forgive the whitespace damage, as this was copied and pasted):
diff --git a/include/trace/events/alarmtimer.h
b/include/trace/events/alarmtimer.h
index 6a34bc9..a4f78cc 100644
--- a/include/trace/events/alarmtimer.h
+++ b/include/trace/events/alarmtimer.h
@@ -77,6 +77,7 @@ DECLARE_EVENT_CLASS(alarm_processing,
                __string(name, process_name)
        ),

+#ifdef CONFIG_RTC_LIB
        TP_fast_assign(
                __entry->expires = alarm->node.expires.tv64;
                __entry->second = rtc_ktime_to_tm(alarm->node.expires).tm_sec;
@@ -89,6 +90,20 @@ DECLARE_EVENT_CLASS(alarm_processing,
                __assign_str(name, process_name);
        ),

+#else
+       TP_fast_assign(
+               __entry->expires = alarm->node.expires.tv64;
+               __entry->second = 0;
+               __entry->minute = 0;
+               __entry->hour = 0;
+               __entry->day = 0;
+               __entry->mon = 0;
+               __entry->year =0;
+               __entry->alarm_type = alarm->type;
+               __assign_str(name, process_name);
+       ),
+#endif
+
        TP_printk("process:%s alarmtimer type:%s expires:%llu "
                  "time: %hu-%u-%u %u:%u:%u",
                  __get_str(name),

Seems to resolve it, but I think a better solution is needed.

thanks
-john

  reply	other threads:[~2016-09-07  0:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021@git.kernel.org>
2016-09-06  9:49 ` [tip:timers/core] time: alarmtimer: Add tracepoints for alarmtimers Ingo Molnar
2016-09-07  0:10   ` John Stultz [this message]
2016-09-07  1:58     ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALAqxLVW8+kVCrB-deEt6mixQLWpwC9TQ0Uw84ew4gJuoDVQ+A@mail.gmail.com \
    --to=john.stultz@linaro.org \
    --cc=baolin.wang@linaro.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).