From: John Stultz <john.stultz@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [GIT PULL] sound updates for 5.9
Date: Mon, 10 Aug 2020 22:10:30 -0700 [thread overview]
Message-ID: <CALAqxLVn2MBp8fy6RFLfWTFNj4X4Wm4JraFWtr3k5aU38X92qw@mail.gmail.com> (raw)
In-Reply-To: <4f3ead7e-992e-edec-e7b4-31566fc5e583@linaro.org>
On Mon, Aug 10, 2020 at 10:06 AM Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
> Hi John,
> Thanks for reporting this.
>
> On 08/08/2020 01:23, John Stultz wrote:
> > q6routing remoteproc-adsp:glink-edge:apr:apr-service@8:routing: ASoC:
> > error at soc_component_read_no_lock on
> > remoteproc-adsp:glink-edge:apr:: -5
>
> This is an -EIO error which is reported when the ASoC component driver
> does not have both regmap and read callback and someone is trying to
> read a register!
>
> In q6routing case all the dapm widgets reuse reg field in
> snd_soc_dapm_widget to store offset information or routing table indexs
> or some DSP related id and so on... These are not real registers.
>
> I think the core is trying to read the state of these widgets during
> startup, Which will fail in qdsp6 case as we do not have any regmap or
> read callback associated with this ASoC component.
>
> Previously we never had chance to see these messages so we did not
> implement any dummy read callback.
>
> Adding a dummy callback to q6routing and q6afe-dai ASoC component will
> fix this issue at-least in Qualcomm case!
Yea, just to confirm. The patch you sent me privately that does the
above seems to work!
Thanks so much!
-john
prev parent reply other threads:[~2020-08-11 5:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 10:21 [GIT PULL] sound updates for 5.9 Takashi Iwai
2020-08-06 21:59 ` pr-tracker-bot
2020-08-08 0:23 ` John Stultz
2020-08-08 6:46 ` Takashi Iwai
2020-08-08 8:07 ` Takashi Iwai
2020-08-10 12:22 ` Mark Brown
2020-08-10 13:52 ` Takashi Iwai
2020-08-08 21:32 ` John Stultz
2020-08-10 17:06 ` Srinivas Kandagatla
2020-08-10 17:50 ` Mark Brown
2020-08-11 5:10 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLVn2MBp8fy6RFLfWTFNj4X4Wm4JraFWtr3k5aU38X92qw@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).