From: John Stultz <john.stultz@linaro.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Chen Yu <chenyu56@huawei.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Biggo Wang <wangbinghui@hisilicon.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, Amit Pundir <amit.pundir@linaro.org>,
Guodong Xu <guodong.xu@linaro.org>
Subject: Re: BUG: scheduling while atomic in f_fs when gadget remove driver
Date: Mon, 3 Oct 2016 12:19:42 -0700 [thread overview]
Message-ID: <CALAqxLW0scq+WxcEZEojdap_UdN7r0aEV6+KxsZ4H2WFXHVXcQ@mail.gmail.com> (raw)
In-Reply-To: <xa1ty42bu2kv.fsf@mina86.com>
On Wed, Sep 28, 2016 at 2:38 PM, Michal Nazarewicz <mina86@mina86.com> wrote:
> On Wed, Sep 28 2016, Michal Nazarewicz wrote:
>> With that done, the only thing which needs a mutex is
>> epfile->read_buffer.
>
> Perhaps this would do:
>
> ---- >8 -------------------------------------------------- -------------
> From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001
> From: Michal Nazarewicz <mina86@mina86.com>
> Date: Wed, 28 Sep 2016 23:36:56 +0200
> Subject: [RFC] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> ffs_func_eps_disable is called from atomic context so it cannot sleep
> thus cannot grab a mutex. Change the handling of epfile->read_buffer
> to use non-sleeping synchronisation method.
>
> Reported-by: Chen Yu <chenyu56@huawei.com>
> Signed-off-by: Michał Nazarewicz <mina86@mina86.com>
> Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests")
So the patch here seems to be in some odd encoding? Can you resend it
using git-send-email or in some way other then embedding it inline
here? Maybe just point me to a git tree that has it?
thanks
-john
next prev parent reply other threads:[~2016-10-03 19:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:44 BUG: scheduling while atomic in f_fs when gadget remove driver Chen Yu
2016-09-27 10:01 ` Felipe Balbi
2016-09-28 9:47 ` Chen Yu
2016-09-28 16:31 ` Michal Nazarewicz
2016-09-28 21:38 ` Michal Nazarewicz
2016-09-30 1:49 ` Chen Yu
2016-10-03 19:19 ` John Stultz [this message]
2016-10-03 20:07 ` Michal Nazarewicz
2016-10-03 20:16 ` John Stultz
2016-10-03 23:36 ` John Stultz
2016-10-04 0:07 ` [PATCH 1/2] usb: gadget: f_fs: edit epfile->ep under lock Michal Nazarewicz
2016-10-04 0:07 ` [PATCH 2/2] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable Michal Nazarewicz
2016-10-04 0:26 ` John Stultz
2016-10-08 6:52 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLW0scq+WxcEZEojdap_UdN7r0aEV6+KxsZ4H2WFXHVXcQ@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=chenyu56@huawei.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).