From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29A0C0018C for ; Sat, 19 Dec 2020 05:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB8BD23C15 for ; Sat, 19 Dec 2020 05:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbgLSFMg (ORCPT ); Sat, 19 Dec 2020 00:12:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbgLSFMg (ORCPT ); Sat, 19 Dec 2020 00:12:36 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBBB8C06138C for ; Fri, 18 Dec 2020 21:11:55 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id 23so10885062lfg.10 for ; Fri, 18 Dec 2020 21:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afa80QgtPdN4Jjvgac+Izd16d6D6uGyqDacL95J8Kgs=; b=v96uyUOCgySZ8diQts47e1XwtLAXXWxfDZ4nvwkOSmqBGPu1cHy3urMpli1Sr4Cexp n4KX4cHVTs7EUJafB6V4beSO2xcFa1r+oJ4Iryde4juhkPSqUzPaCpH0tA7oQ1Cj3YVL IXvRIahVtyXcuEP03XO7JMNs3xG2Bb/J7cvYINGYJiU7c+gpnCgbckc8TXHq+KSAvkSa mo82FZQCxr2nUmuf0LYt5gI33ogPnp4c8wi0SKg5juZJvmVH6hQuhyXorKL/jl8ln5NY HWmcL/j+K4F/X/eAL2TsGqKQIOdaP0RMZdvefRTlVQNCrfAmzrp6rXPG+ZqGgLtZdMJk smNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afa80QgtPdN4Jjvgac+Izd16d6D6uGyqDacL95J8Kgs=; b=cBWh6d13YNdLr/axG1F7ZJYwoQx1sD10UN5+BDzxOEJDx3XorDgUGACCFEcXqq5Y6n 2kkouJVHn3qPfspt65JfmPIsA2unC/DM6O2a8U4CvPrqqyib76uCiYciX/jWt2Q3ScTs m3JS6aKaNXTygwhpXascUDlgJCiKZ6U1g1yISPOsv9+XMPrNoIElEZOL0gLR+tNz56lT IFEC+U1EqUl22+us/QQmwicVetB00dEOpAV/E+V/aYlcA9UzgftLczpQVP//eRldYaYZ a2fk5wvtrf2+9IR57DbGVRa5EocQkDzJEp0es3Iuj31tNVqk+hwmKjvMyAchATLZEDF9 K5qQ== X-Gm-Message-State: AOAM531O88V/O3hsqLlmaPr7eO0q1sW8MqQnumpwDMc/lS9uXMYsMnYO uCHYK0+VIYVVaSO1Bcaodo3LcX0xuXZsz9xMyaCorw== X-Google-Smtp-Source: ABdhPJwsnxxJaMYLww2D9QJdNd+4q/UnYTnJhT0tzTVHJqG5oycz+3OTASkLqi6ZlnoTvY+pFeJvV7w1QDbuFdN1C6A= X-Received: by 2002:a19:4a4a:: with SMTP id x71mr2877672lfa.535.1608354714024; Fri, 18 Dec 2020 21:11:54 -0800 (PST) MIME-Version: 1.0 References: <20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru> <20201111091552.15593-17-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20201111091552.15593-17-Sergey.Semin@baikalelectronics.ru> From: John Stultz Date: Fri, 18 Dec 2020 21:11:42 -0800 Message-ID: Subject: Re: [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name To: Serge Semin Cc: Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Rob Herring , Greg Kroah-Hartman , Wei Xu , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , Serge Semin , lkml , YongQin Liu , Amit Pundir Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 1:22 AM Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > named. > > Signed-off-by: Serge Semin > Acked-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > index d25aac5e0bf8..aea3800029b5 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > @@ -1166,7 +1166,7 @@ usb_phy: usb-phy { > }; > }; > > - dwc3: dwc3@ff100000 { > + dwc3: usb@ff100000 { > compatible = "snps,dwc3"; > reg = <0x0 0xff100000 0x0 0x100000>; Oof. So this patch is breaking the usb gadget functionality on HiKey960 w/ AOSP. In order to choose the right controller for gadget mode with AOSP, one sets the "sys.usb.controller" property, which until now for HiKey960 has been "ff100000.dwc3". After this patch, the controller isn't found and we would have to change userland to use "ff100000.usb", which would then break booting on older kernels (testing various LTS releases on AOSP is one of the key uses of the HiKey960). So while I understand the desire to unify the schema, as HiKey960 really isn't likely to be used outside of AOSP, I wonder if reverting this one change is in the best interest of not breaking existing userland? thanks -john