From: John Stultz <john.stultz@linaro.org>
To: Hillf Danton <hdanton@sina.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Simon Ser <contact@emersion.fr>,
Christoph Hellwig <hch@infradead.org>,
James Jones <jajones@nvidia.com>,
linux-media <linux-media@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap
Date: Thu, 29 Oct 2020 15:28:34 -0700 [thread overview]
Message-ID: <CALAqxLWUhugbjOGMnSciUN+nSR48u+ph07BRp7US7w+ix6fT+A@mail.gmail.com> (raw)
In-Reply-To: <20201029071037.2913-1-hdanton@sina.com>
On Thu, Oct 29, 2020 at 12:10 AM Hillf Danton <hdanton@sina.com> wrote:
> On Thu, 29 Oct 2020 00:16:24 +0000 John Stultz wrote:
> > @@ -194,6 +210,9 @@ static int system_heap_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
> > struct sg_page_iter piter;
> > int ret;
> >
> > + if (buffer->uncached)
> > + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
> > +
>
> Wonder why you turn back to dma_mmap_wc() and friends?
Sorry, can you expand on what you are proposing here instead? I'm not
sure I see how dma_alloc/mmap/*_wc() quite fits here.
thanks
-john
next prev parent reply other threads:[~2020-10-29 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:16 [RESEND][PATCH v4 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation John Stultz
2020-10-29 0:16 ` [PATCH v4 1/7] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists John Stultz
2020-10-29 0:16 ` [PATCH v4 2/7] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation John Stultz
2020-10-29 0:16 ` [PATCH v4 3/7] dma-buf: heaps: Remove heap-helpers code John Stultz
2020-10-29 0:16 ` [PATCH v4 4/7] dma-buf: heaps: Skip sync if not mapped John Stultz
2020-10-29 0:16 ` [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available John Stultz
[not found] ` <20201029070221.2856-1-hdanton@sina.com>
2020-10-29 19:34 ` John Stultz
2020-10-29 0:16 ` [PATCH v4 6/7] dma-buf: dma-heap: Keep track of the heap device struct John Stultz
2020-10-29 0:16 ` [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap John Stultz
[not found] ` <20201029071037.2913-1-hdanton@sina.com>
2020-10-29 22:28 ` John Stultz [this message]
[not found] <20201030075023.3250-1-hdanton@sina.com>
2020-10-30 19:21 ` John Stultz
[not found] <20201030024746.3128-1-hdanton@sina.com>
2020-10-30 4:04 ` John Stultz
-- strict thread matches above, loose matches on Subject: below --
2020-10-17 1:32 [PATCH v4 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation John Stultz
2020-10-17 1:32 ` [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLWUhugbjOGMnSciUN+nSR48u+ph07BRp7US7w+ix6fT+A@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=jajones@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).