From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757715AbbLBVbm (ORCPT ); Wed, 2 Dec 2015 16:31:42 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:35046 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbbLBVbj (ORCPT ); Wed, 2 Dec 2015 16:31:39 -0500 MIME-Version: 1.0 In-Reply-To: <20151202205745.GA28256@kroah.com> References: <20151202205745.GA28256@kroah.com> Date: Wed, 2 Dec 2015 13:31:38 -0800 Message-ID: Subject: Re: [REGRESSION] b8b2c7d845 breaks suspend/resume in qemu From: John Stultz To: Greg Kroah-Hartman Cc: martin.wilck@ts.fujitsu.com, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 2, 2015 at 12:57 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 02, 2015 at 12:46:10PM -0800, John Stultz wrote: >> On Wed, Dec 2, 2015 at 12:39 PM, John Stultz wrote: >> > Hey Uwe, >> > >> > So I recently noticed that my alarmtimer suspend/resume tests >> > (selftests/timers/alartimer-suspend.c) were getting stuck testing w/ >> > 4.4-rc kernels when running under qemu (x86_64). >> > >> > I've bisected this back to: b8b2c7d845 (base/platform: assert that >> > dev_pm_domain callbacks are called unconditionally). >> > >> > I've not yet spent done any further analysis (bisecting it down, after >> > some user-error, ate up my morning). But I wanted to see if there were >> > any initial suggestions for solving this. >> >> Just one other quick note: Reverting this commit against 4.4-rc3 seems >> to work as well. > > There's a proposed patch to resolve this on the mailing list, "Subject: > [PATCH] base/platform: fix panic when probe function is NULL" from > Martin, but I think he's going to send me an updated version before I > forward it on to Linus. > > It should resolve your issue, can you verify that? Yep. That fix seems to avoid the problem for me. thanks -john