From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752016AbcGNRaw (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jul 2016 13:30:52 -0400
Received: from mail-oi0-f46.google.com ([209.85.218.46]:36065 "EHLO
	mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751402AbcGNRaq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jul 2016 13:30:46 -0400
MIME-Version: 1.0
In-Reply-To: <20160714171311.GB13434@redhat.com>
References: <20160713183347.GK4065@mtj.duckdns.org> <CALAqxLU76kVm8b5GNnSk25-Xk6D1efiWtwNJbY1th_pcN9Ks=g@mail.gmail.com>
 <20160713201823.GB29670@mtj.duckdns.org> <20160713202657.GW30154@twins.programming.kicks-ass.net>
 <20160713203944.GC29670@mtj.duckdns.org> <20160713205102.GZ30909@twins.programming.kicks-ass.net>
 <20160714131809.GO30927@twins.programming.kicks-ass.net> <CALAqxLWdS4jv8a=bcF433DivjzH-sWsM6BCvW3Apy+JDdN3nMw@mail.gmail.com>
 <20160714164945.GH30154@twins.programming.kicks-ass.net> <CALAqxLWRNd=9gaVWUeH=u5iMVdGPmP_gZMwNf2Tk9BKn9BL1VA@mail.gmail.com>
 <20160714171311.GB13434@redhat.com>
From: John Stultz <john.stultz@linaro.org>
Date: Thu, 14 Jul 2016 10:30:44 -0700
Message-ID: <CALAqxLX+1h4DCqOGBpfb3CKg_2CUiV3Nc=HQqdi_E+7U4QEFbQ@mail.gmail.com>
Subject: Re: Severe performance regression w/ 4.4+ on Android due to cgroup
 locking changes
To: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, lkml <linux-kernel@vger.kernel.org>,
        Dmitry Shmidt <dimitrysh@google.com>,
        Rom Lemarchand <romlem@google.com>, Colin Cross <ccross@google.com>,
        Todd Kjos <tkjos@google.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 14, 2016 at 10:13 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 07/14, John Stultz wrote:
>>
>> So I am seeing synchronize_sched called, and its taking the
>> !rcu_gp_is_expedited path when I see the particularly bad latencies.
>>
>> I wonder if I just mucked up applying the patch?
>
> Probably yes...

Hm. So I applied peterz patch to 4.7-rc7 and then diffed it to what I
had and it was just whitespace changes.

I've synched them up now, so I suspect my application isn't the issue
now. Just to be clear, I'm not supposed to be applying this on-top of
Paul's change, right?


> Just in case, could you try the patch below? Of course, without other
> optimizations from Peter, this change makes cgroup_threadgroup_rwsem
> much worse than a plain rw_semaphore.
>
> Oleg.
>
> --- x/kernel/cgroup.c
> +++ x/kernel/cgroup.c
> @@ -5605,6 +5605,8 @@ int __init cgroup_init(void)
>         BUG_ON(cgroup_init_cftypes(NULL, cgroup_dfl_base_files));
>         BUG_ON(cgroup_init_cftypes(NULL, cgroup_legacy_base_files));
>
> +       rcu_sync_enter(&cgroup_threadgroup_rwsem.rss);
> +


So adding this does make a huge difference ontop of Peter's patch. I'm
seeing sub 200us values for everything. The biggest spike in my basic
testing has been 138us.

I'm also not seeing synchronize_sched being called nearly as often,
and it doesn't seem to be being called in cgroup_procs_write path.

thanks
-john