From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753068AbcFJHJM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 03:09:12 -0400
Received: from mail-oi0-f46.google.com ([209.85.218.46]:34592 "EHLO
	mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750871AbcFJHJK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 03:09:10 -0400
MIME-Version: 1.0
In-Reply-To: <201606101452.yH3kUYBO%fengguang.wu@intel.com>
References: <1465536877-18452-2-git-send-email-john.stultz@linaro.org> <201606101452.yH3kUYBO%fengguang.wu@intel.com>
From: John Stultz <john.stultz@linaro.org>
Date: Fri, 10 Jun 2016 00:09:08 -0700
Message-ID: <CALAqxLXJvobujmefa3cnLt4US3MAPmTkjjkMv2H6tK-tk86Tzg@mail.gmail.com>
Subject: Re: [PATCH 1/3] drivers: input: powerkey for HISI 65xx SoC
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, lkml <linux-kernel@vger.kernel.org>,
        Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Lee Jones <lee.jones@linaro.org>,
        Feng Chen <puck.chen@hisilicon.com>, Wei Xu <xuwei5@hisilicon.com>,
        Guodong Xu <guodong.xu@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 9, 2016 at 11:44 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi,
>
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v4.7-rc2 next-20160609]
> [cannot apply to input/next]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/John-Stultz/Hi655x-powerkey-support-for-HiKey-v3/20160610-133804
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All error/warnings (new ones prefixed by >>):
>
>    In file included from drivers/input/misc/hisi_powerkey.c:21:0:
>>> drivers/input/misc/hisi_powerkey.c:135:25: error: 'hi65xx_powerkey_of_match' undeclared here (not in a function)
>     MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match);
>                             ^
>    include/linux/module.h:223:21: note: in definition of macro 'MODULE_DEVICE_TABLE'
>     extern const typeof(name) __mod_##type##__##name##_device_table  \
>                         ^~~~
>>> include/linux/module.h:223:27: error: '__mod_of__hi65xx_powerkey_of_match_device_table' aliased to undefined symbol 'hi65xx_powerkey_of_match'
>     extern const typeof(name) __mod_##type##__##name##_device_table  \
>                               ^
>>> drivers/input/misc/hisi_powerkey.c:135:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
>     MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match);
>     ^~~~~~~~~~~~~~~~~~~

Yep. Sorry, I realized right after I sent this that I had left the
MODULE_DEVICE_TABLE entry in there. I've already yanked it in my tree
and will resubmit with the fix next week.

Please do let me know if you have any other feedback or issues in the meantime!

Apologies and Thanks!
-john