From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81310C11F67 for ; Wed, 14 Jul 2021 00:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 687916052B for ; Wed, 14 Jul 2021 00:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237131AbhGNAKG (ORCPT ); Tue, 13 Jul 2021 20:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236966AbhGNAKF (ORCPT ); Tue, 13 Jul 2021 20:10:05 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF83C0613EE for ; Tue, 13 Jul 2021 17:07:14 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id a12so355285lfb.7 for ; Tue, 13 Jul 2021 17:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IEtc6WN0JMkgA1X93JOHMXDth957tk+vFhRSm4MpLAM=; b=kjXNNfOnOZfSXBl9SvNCTU7DVpgzZWIJVg9FqMS+1JX+6OMWWH9CLz877AqiHOprT/ /lsKfkuIYEXI5WFMO1UydRgKvGakHia0Zef/k9HPAsht+GzeUkroxtZWMCQ2STLroRkq FbqTR01kbBnrLWRZIyDwPLNuRZw8bHlvVIeiols+N3IWOXnQTDwnr76itERqCDK3hsXZ ftqKLC+BlDomCfes9K25/WuyzNNNMkx43ZllqSA63P/fqo0Y8nrvLk14aMTDmLSU3tmX DEurRNdYe9gDg4EtE+LjmrSjSrKtx9TtcvisAvYwwvXgU6rLgKJAohSbtf0H2B/+yt/o Sq6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IEtc6WN0JMkgA1X93JOHMXDth957tk+vFhRSm4MpLAM=; b=QX5Lw6yX/utWoHDEVxJGF0hIup7R/V3hNjcNROgfDfqknDkrNZW76imQFgD2H8NfQb l4UVbYPWBLXzezCqfvRcLNtNKBzcG0wm9i9EZGxPX/9MteC9SwjHqVH/HNrqnP+MpMF8 sTHKb59EU+DATUwqIgqk4W8j1DARNeLdvx/UB5bEqa+jbE3tSmrwJ70WAh07DlsbIZsU /nUstdOyeZXXM3GI/iDBp/WiShumTioEKp+KdBhpkiz/2UDCN2lHMpDA5QtSEsAIhAQn 6+/V8AoGMTG386t+DBMQ41afpflKgUrTgNP5hha4wczL/vWEmcvkXSAX345XntR8gL5u uNkQ== X-Gm-Message-State: AOAM532kJh1z6kXI/lE7eItaXPOsTzh2Aq6aYseGq8SMMvsPRZyyps03 FN+RTQ2fAdV0MX39UBqG1l2Duz0ugbEq27iqViWqqQ== X-Google-Smtp-Source: ABdhPJz8YKla708wW5apcE2e48dD+UxOPlSdmQcDXhRj1YqgSttTekZln8X6HfzXhD+WqceB5w0KiAl65c8UEeH/5gw= X-Received: by 2002:a05:6512:22cc:: with SMTP id g12mr5427042lfu.535.1626221232412; Tue, 13 Jul 2021 17:07:12 -0700 (PDT) MIME-Version: 1.0 References: <20201020115959.2658-1-Sergey.Semin@baikalelectronics.ru> <20201020115959.2658-30-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20201020115959.2658-30-Sergey.Semin@baikalelectronics.ru> From: John Stultz Date: Tue, 13 Jul 2021 17:07:00 -0700 Message-ID: Subject: Re: [PATCH 29/29] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name To: Serge Semin Cc: Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Rob Herring , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux USB List , lkml , Serge Semin , linux-arm-kernel , Amit Pundir Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2020 at 5:10 AM Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > named. > > Signed-off-by: Serge Semin I know folks like to ignore this, but this patch breaks AOSP on db845c. :( In the exact same way an earlier patch broke HiKey960: https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ (which I still have to carry a revert for). I get that this change is useful so more dynamic userland can find devices using consistent naming with future kernels (but doesn't the dynamic userland have to handle the case for older kernels as well?) But for userland that uses static configs, its painful as updating userland to use the new node ids then causes older kernels to fail. I'm looking into how we might be able to probe and set the property dynamically, but AOSP's init system is far more aligned to static configs. This will probably be ignored again, but it would be nice if we could have a release where DTS changes don't break userland for one of my boards. As it feels like its been awhile. thanks -john